Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v31.3.0 #88881

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Upgrade EUI to v31.3.0 #88881

merged 5 commits into from
Jan 25, 2021

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jan 20, 2021 •
edited
Loading

31.0.0 ➡️ 31.3.0

All snapshot changes from:

  • Added a textSize prop to EuiHealth (#4420)
  • Reduced the size of the icons and clear button for compressed EuiFormControlLayout (#4374)

31.3.0

  • Added a size prop to EuiContextMenu and added a smaller size (#4409)
  • Added a textSize prop to EuiHealth (#4420)
  • Removed selected item of EuiSelect when hasNoInitialSelection=true and value reset to undefined (#4428)

31.2.0

  • Added support for adjusting buffer for individual window sides of EuiPopover. (#4417)
  • Added 'full' option to the height prop of EuiMarkdownEditor. Added autoExpandPreview and maxHeight props to EuiMarkdownEditor (#4245)

31.1.0

  • Reduced the size of the icons and clear button for compressed EuiFormControlLayout (#4374)
  • Added ability for text input updates in EuiDatePicker (#4243)
  • [REVERTED in 31.3.0] Fixed heights of append and prepend in EuiFormControlLayout (#4410)

Bug fixes

  • Fixed EuiSuperDatePicker extra margin when showUpdateButton and isAutoRefreshOnly are active (#4406)

@chandlerprall chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.12.0 labels Jan 20, 2021
@chandlerprall chandlerprall marked this pull request as ready for review January 21, 2021 16:05
@chandlerprall chandlerprall requested review from a team as code owners January 21, 2021 16:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@chandlerprall chandlerprall requested a review from a team as a code owner January 21, 2021 18:16
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jan 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elizabetdev
Copy link
Contributor

FYI as part of elastic/eui#4406 (review), I pushed a small fix 69ea196.

justinkambic
justinkambic approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM.

cjcenizal
cjcenizal approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES UI snapshot changes LGTM

lizozom
lizozom approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is only snapshot diff

@lizozom
Copy link
Contributor

lizozom commented Jan 25, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

We show one primary callout.Detections > Callouts indicating read-only access to resources On Detections home page We show one primary callout

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-test-subj="callout-read-only-access-to-alerts"]`, but never found it.
    at Object.waitForCallOutToBeShown (http://localhost:6121/__cypress/tests?p=cypress/integration/detection_alerts/alerts_detection_callouts_readonly.spec.ts:21499:10)
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/detection_alerts/alerts_detection_callouts_readonly.spec.ts:20284:24)
We hide it and persist the dismissal.Detections > Callouts indicating read-only access to resources On Detections home page When a user clicks Dismiss on the callout We hide it and persist the dismissal

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-test-subj="callout-read-only-access-to-alerts"]`, but never found it.
    at Object.waitForCallOutToBeShown (http://localhost:6121/__cypress/tests?p=cypress/integration/detection_alerts/alerts_detection_callouts_readonly.spec.ts:21499:10)
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/detection_alerts/alerts_detection_callouts_readonly.spec.ts:20288:28)
We hide it and persist the dismissal.Detections > Callouts indicating read-only access to resources On Rules Management page When a user clicks Dismiss on the callout We hide it and persist the dismissal

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-test-subj="callout-read-only-access-to-rules"]`, but never found it.
    at Object.waitForCallOutToBeShown (http://localhost:6121/__cypress/tests?p=cypress/integration/detection_alerts/alerts_detection_callouts_readonly.spec.ts:21499:10)
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/detection_alerts/alerts_detection_callouts_readonly.spec.ts:20304:28)

and 1 more failures, only showing the first 3.

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +74.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 1013.3KB 1013.3KB +24.0B
Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
css 673.9KB 675.3KB +1.4KB
[email protected] 2.4MB 2.4MB +7.0KB
total +8.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@justinkambic justinkambic mentioned this pull request Jan 25, 2021
Open
patrykkopycinski
patrykkopycinski approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIEM/Endpoint app LGTM

myasonik
myasonik approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

clintandrewhall
clintandrewhall approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the changes look passive on my end. Thanks!

@chandlerprall chandlerprall merged commit 5d68b10 into elastic:master Jan 25, 2021
@chandlerprall chandlerprall deleted the eui_31_3_0 branch January 25, 2021 21:39
@chandlerprall chandlerprall mentioned this pull request Jan 25, 2021
Merged
chandlerprall added a commit to chandlerprall/kibana that referenced this pull request Jan 25, 2021
@chandlerprall @elizabetdev @kibanamachine
Upgrade EUI to v31.3.0 (elastic#88881)
3761628 
* Bump EUI to v31.3.0

* jest snapshot updates

* Fixed space issue in kbnQueryBar date picker

* Removed unecessary space in query bar scss

Co-authored-by: miukimiu <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
chandlerprall added a commit that referenced this pull request Jan 26, 2021
@chandlerprall @elizabetdev @kibanamachine
Upgrade EUI to v31.3.0 (#88881) (#89235)
a245def 
* Bump EUI to v31.3.0

* jest snapshot updates

* Fixed space issue in kbnQueryBar date picker

* Removed unecessary space in query bar scss

Co-authored-by: miukimiu <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: miukimiu <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@myasonik myasonik myasonik approved these changes

@lizozom lizozom lizozom approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@clintandrewhall clintandrewhall clintandrewhall approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.