Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unit tests using enzyme render to avoid EUI upgrade mentions #288

Open
justinkambic opened this issue Jan 25, 2021 · 0 comments
Open

Comments

@justinkambic
Copy link

Today, when the EUI team upgrades to a new version we are frequently mentioned for CODEOWNER review when snapshots change. These almost always change because the EUI team adds some new class or attribute to the components they maintain, which then break our snaps.

Given that they only merge breaking changes for majors, we can reduce a marginal amount of noise for ourselves and work for the EUI maintainers by refactoring any test that breaks when an upgrade happens. In the example PR linked above, two of our test suites required such revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant