You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Today, when the EUI team upgrades to a new version we are frequently mentioned for CODEOWNER review when snapshots change. These almost always change because the EUI team adds some new class or attribute to the components they maintain, which then break our snaps.
Given that they only merge breaking changes for majors, we can reduce a marginal amount of noise for ourselves and work for the EUI maintainers by refactoring any test that breaks when an upgrade happens. In the example PR linked above, two of our test suites required such revision.
The text was updated successfully, but these errors were encountered:
Today, when the EUI team upgrades to a new version we are frequently mentioned for CODEOWNER review when snapshots change. These almost always change because the EUI team adds some new class or attribute to the components they maintain, which then break our snaps.
Given that they only merge breaking changes for majors, we can reduce a marginal amount of noise for ourselves and work for the EUI maintainers by refactoring any test that breaks when an upgrade happens. In the example PR linked above, two of our test suites required such revision.
The text was updated successfully, but these errors were encountered: