[EuiFormControlLayout] Use smaller icons when in compressed size #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4374/ |
|
I'm slightly confused by your screenshot because the heights of both inputs are the same 😕 . Is this just a faked screenshot? |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4374/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4374/ |
cchaos
requested review from
snide and
chandlerprall
and removed request for
cchaos
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4374/ |
snide
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reduces the size of the icon and clear button in
EuiFormControlLayoutwhen using thecompressedversion.It was intentional to leave the loading icon larger (for now) because the small size was too small and not equivelant to the small size of icons.
This PR also currently ignores the custom implementation of the file picker.
Checklist
- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes