Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiComboBox] Fixed icons' and buttons' sizes in append/prepend #4410

Merged
merged 4 commits into from
Jan 11, 2021
Merged

[EuiComboBox] Fixed icons' and buttons' sizes in append/prepend #4410

merged 4 commits into from
Jan 11, 2021

Conversation

Dishebh
Copy link
Contributor

@Dishebh Dishebh commented Jan 5, 2021 •
edited
Loading

Summary

Fixes #4407
Fixed icons' and buttons' sizes in append/prepend in EuiComboBox

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4410/

thompsongl
thompsongl suggested changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
The primary change LGTM. Just need to update the changelog entry.

CHANGELOG.md Outdated Show resolved Hide resolved
@cchaos
Copy link
Contributor

cchaos commented Jan 5, 2021

This change scares me just a little bit. We'll want to do some extensive testing with the different types of inputs and prepend/appends before merging this. I'll try to pull it down later today.

@thompsongl thompsongl self-requested a review January 5, 2021 19:00
cchaos
cchaos approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this on Chrome, FF, and Safari and checked the compressed sizes with all the different content (popovers, buttons, text) and it all seems to be just swell.

Thanks @Dishebh !!

@cchaos
Copy link
Contributor

cchaos commented Jan 11, 2021

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4410/

@cchaos cchaos merged commit 75ca1a9 into elastic:master Jan 11, 2021
@Dishebh Dishebh deleted the combo branch January 12, 2021 06:02
@cchaos cchaos mentioned this pull request Jan 19, 2021
Closed
chandlerprall added a commit to chandlerprall/eui that referenced this pull request Jan 19, 2021
@chandlerprall
Revert "[EuiFormControlLayout] Fixed heights of append/prepend (elast…
3790a8f 
…ic#4410)"

This reverts commit 75ca1a9.
chandlerprall added a commit to chandlerprall/eui that referenced this pull request Jan 19, 2021
@chandlerprall
Revert "[EuiFormControlLayout] Fixed heights of append/prepend (elast…
1d2f99d 
…ic#4410)"

This reverts commit 75ca1a9.
@chandlerprall chandlerprall mentioned this pull request Jan 19, 2021
Merged
chandlerprall added a commit that referenced this pull request Jan 19, 2021
@chandlerprall
Revert "[EuiFormControlLayout] Fixed heights of append/prepend (#4410)…
e8f675e 
…" (#4432)

* Revert "[EuiFormControlLayout] Fixed heights of append/prepend (#4410)"

This reverts commit 75ca1a9.

* changelog tweak

* lint fix
@chandlerprall chandlerprall mentioned this pull request Jan 20, 2021
Merged
@chandlerprall chandlerprall mentioned this pull request Jan 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@thompsongl thompsongl Awaiting requested review from thompsongl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiComboBox] Icons and buttons not correctly sized in append/prepend
4 participants
@Dishebh @kibanamachine @thompsongl @cchaos