Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v31.4.0 #89648

Merged
merged 22 commits into from
Feb 5, 2021
Merged

Upgrade EUI to v31.4.0 #89648

merged 22 commits into from
Feb 5, 2021

Conversation

chandlerprall
Copy link
Contributor

31.3.0 ➡️ 31.4.0

31.4.0

  • Added getDefaultEuiMarkdownProcessingPlugins method for better control over EuiMarkdownEditor's toolbar UI (#4383)
  • Changed EuiOutsideClickDetector events to be standard event types (#4434)
  • Added EuiFieldTextProps in type definitions for EuiSuggestInput (#4452)
  • Added virtualized cell rendering to EuiDataGrid (#4170)

Bug fixes

  • Fixed heights of append and prepend in EuiComboBox (#4410)
  • Fixed EuiResizableContainer initialization timing based on DOM readiness (#4447)

@chandlerprall chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.12.0 labels Jan 28, 2021
@chandlerprall
Copy link
Contributor Author

jenkins test this

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@chandlerprall
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@chandlerprall chandlerprall marked this pull request as ready for review February 3, 2021 13:20
@chandlerprall chandlerprall requested a review from a team February 3, 2021 13:20
@chandlerprall chandlerprall requested a review from a team as a code owner February 3, 2021 13:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

flash1293
flash1293 approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Lens - data table is much much faster now!

@kertal
Copy link
Member

kertal commented Feb 5, 2021

@elasticmachine merge upstream

kertal
kertal approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small step for Kibana, a big step for Discover, great improvement, tested locally with Chrome using a build of this PR. Issue is now the legacy grid because it is much slower then expected?

walterra
walterra approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested data grids in ML and transform plugin, great update! Just let me know if you're going to update the commented test part or if we should pick it up once it's in.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
css 675.3KB 677.2KB +1.9KB
[email protected] 2.4MB 2.4MB +5.4KB
kbn-ui-shared-deps.js 7.0MB 7.0MB +11.2KB
total +18.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal mentioned this pull request Feb 5, 2021
Merged
1 task
@chandlerprall chandlerprall merged commit db899a9 into elastic:master Feb 5, 2021
@chandlerprall chandlerprall deleted the eui-31-4-0 branch February 5, 2021 17:15
@chandlerprall chandlerprall mentioned this pull request Feb 5, 2021
Merged
chandlerprall added a commit to chandlerprall/kibana that referenced this pull request Feb 5, 2021
@chandlerprall @kibanamachine
@flash1293 @kertal
Upgrade EUI to v31.4.0 (elastic#89648)
be3b93b 
* Bump EUI to v31.4.0

* fix datagrid functional tests

* fix Lens unit tests

* fix table cell filter test

* Fix discover grid doc view test

* stabilize data table tests

* fix dashboard embeddable datagrid test

* Fix x-pack functional tests

* fix ml accessibility tests

* Fix discover grid context test

* Adapt expected nr of documents being displayed

* stabilize Lens a11y tests and skip data table

* Fix 2 ml functional tests

* enable lens datatable test; disable axe rule for datatable

* fix ml test

* fix Lens table test

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: Matthias Wilhelm <[email protected]>
Co-authored-by: Michail Yasonik <[email protected]>
chandlerprall added a commit that referenced this pull request Feb 5, 2021
@chandlerprall @kibanamachine
@flash1293 @kertal
Upgrade EUI to v31.4.0 (#89648) (#90462)
d18bdb0 
* Bump EUI to v31.4.0

* fix datagrid functional tests

* fix Lens unit tests

* fix table cell filter test

* Fix discover grid doc view test

* stabilize data table tests

* fix dashboard embeddable datagrid test

* Fix x-pack functional tests

* fix ml accessibility tests

* Fix discover grid context test

* Adapt expected nr of documents being displayed

* stabilize Lens a11y tests and skip data table

* Fix 2 ml functional tests

* enable lens datatable test; disable axe rule for datatable

* fix ml test

* fix Lens table test

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: Matthias Wilhelm <[email protected]>
Co-authored-by: Michail Yasonik <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: Matthias Wilhelm <[email protected]>
Co-authored-by: Michail Yasonik <[email protected]>
@flash1293 flash1293 mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@kertal kertal kertal approved these changes

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chandlerprall @flash1293 @elasticmachine @kertal @kibanamachine @walterra