Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[EuiFormControlLayout] Fixed heights of append/prepend (#4410)" #4432

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jan 19, 2021

Summary

This reverts commit 75ca1a9 from #4410. See discussion in #4431. @miukimiu will follow up with a better resolutioon.

@chandlerprall chandlerprall requested a review from cchaos January 19, 2021 17:32
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Quick suggestion for the CL

CHANGELOG.md Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4432/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4432/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4432/

@chandlerprall chandlerprall merged commit e8f675e into elastic:master Jan 19, 2021
@chandlerprall chandlerprall deleted the revert/4410 branch January 19, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants