[EuiPopover] Allow adjusting buffer for individual window sides.
#4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
ashikmeerankutty
changed the title
buffer for individual window sides #4414buffer for individual window sides.
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4417/ |
thompsongl
suggested changes
Jan 11, 2021
There was a problem hiding this comment.
Thanks, @ashikmeerankutty!
Just the type update required. It'd be great to update the test, also, to account for arrays.
|
@thompsongl Thank you for the review. Changes updated and added tests. Please do review. |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4417/ |
thompsongl
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4414
Added support for adjusting
bufferfor individual window sides.Checklist
- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples