-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacing issue resolved #4263 #4406
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
I have signed the contribution agreement as stated above. |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4406/ |
Thank you for this PR! We're all currently enjoying some time off for the holidays, and someone will take a look next week! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Vivek-Kamboj,
Thanks for fixing this bug! 🎉
I added a changelog and tested the changes in different browsers: Edge, Firefox, Chrome, and Safari. Also tested in small screen sizes and your fix works fine.
I also removed the max-width
from euiSuperDatePicker__flexWrapper--isAutoRefreshOnly
.
I tried to find why the max-width
was introduced and I found that it was meant to fix an issue referenced here: #2236 (comment). This fix is no longer needed IMO.
@cchaos, this fix will introduce a small issue in Kibana.
To fix it, we need to move line 76 into .kbnQueryBar__datePickerWrapper-isHidden
:
@@ -6,12 +6,10 @@ | |||
|
|||
.euiSuperDatePicker__flexWrapper--isAutoRefreshOnly { | |||
width: $euiFormMaxWidth; | |||
max-width: 100% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The max-width
is now calc(100% + #{$euiSizeS});
that is part of .euiSuperDatePicker__flexWrapper
.
Summary
I have removed "max-width:100%" from this className
This is because we are giving "margin:-4px" and it is creating some margin in right when we put "max-width:100%" but after removing, it is working fine.
Here is the screenshot of before and after the change.
Before:
After:
Checklist