Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing issue resolved #4263 #4406

Merged
merged 5 commits into from
Jan 4, 2021
Merged

Spacing issue resolved #4263 #4406

merged 5 commits into from
Jan 4, 2021

Conversation

Vivek-Kamboj
Copy link
Contributor

Summary

I have removed "max-width:100%" from this className
Code

This is because we are giving "margin:-4px" and it is creating some margin in right when we put "max-width:100%" but after removing, it is working fine.

Here is the screenshot of before and after the change.
Before:
Before
After:
After

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Dec 28, 2020

💚 CLA has been signed

@Vivek-Kamboj
Copy link
Contributor Author

I have signed the contribution agreement as stated above.
Please review now.

@elizabetdev
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4406/

@chandlerprall
Copy link
Contributor

Thank you for this PR! We're all currently enjoying some time off for the holidays, and someone will take a look next week!

@elizabetdev elizabetdev self-requested a review January 4, 2021 14:52
Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vivek-Kamboj,

Thanks for fixing this bug! 🎉

I added a changelog and tested the changes in different browsers: Edge, Firefox, Chrome, and Safari. Also tested in small screen sizes and your fix works fine.

I also removed the max-width from euiSuperDatePicker__flexWrapper--isAutoRefreshOnly.

I tried to find why the max-width was introduced and I found that it was meant to fix an issue referenced here: #2236 (comment). This fix is no longer needed IMO.

@cchaos, this fix will introduce a small issue in Kibana.

Screenshot 2021-01-04 at 18 02 24

To fix it, we need to move line 76 into .kbnQueryBar__datePickerWrapper-isHidden:

https://github.com/elastic/kibana/blob/6b4e88fae14b4d665082a17ebc6cae3916ad5cb0/src/plugins/data/public/ui/query_string_input/_query_bar.scss#L70-L84

@elizabetdev elizabetdev added the bug label Jan 4, 2021
@@ -6,12 +6,10 @@

.euiSuperDatePicker__flexWrapper--isAutoRefreshOnly {
width: $euiFormMaxWidth;
max-width: 100%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max-width is now calc(100% + #{$euiSizeS}); that is part of .euiSuperDatePicker__flexWrapper.

@elizabetdev elizabetdev merged commit 6ffbd66 into elastic:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants