Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSuperDatePicker] Renders whitespace when update/refresh button is hidden #4263

Closed
jen-huang opened this issue Nov 12, 2020 · 2 comments
Closed

[EuiSuperDatePicker] Renders whitespace when update/refresh button is hidden #4263

jen-huang opened this issue Nov 12, 2020 · 2 comments
Labels
good first issue

Comments

@jen-huang
Copy link
Contributor

When using showUpdateButton={false} on EuiSuperDatePicker, extra space to the right of the component is rendered. I've illustrated this below using a simple EuiFlexGroup tree with gutter size set to none.

Demo: https://codesandbox.io/s/dreamy-moon-g6xml?file=/index.js:2046-2070

With the update button shown, the sibling EuiFlexItem renders flush against the date picker:
image

When the update button is hidden, observe the extra space:
image
@Vivek-Kamboj
Copy link
Contributor

Hi @jen-huang,
I am interested in working on this issue.

@Vivek-Kamboj
Copy link
Contributor

Hi @jen-huang @cchaos,
I have raised the Pull Request for this issue.
PR: 8131b5a
Issue: #4263
Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cchaos @jen-huang @Vivek-Kamboj