Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v30.6.0 #85504

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Upgrade EUI to v30.6.0 #85504

merged 3 commits into from
Dec 14, 2020

Conversation

chandlerprall
Copy link
Contributor

Summary

[email protected] ⏩ [email protected]

Snapshot changes are almost entirely from:

  • buttons receiving disabled={false} as we began computing the disabled prop in link-related components (#4362)
  • buttons receiving an explicit type="button" in a few places (#4368)
  • two colors were added to EuiButtonEmpty (#4325)

30.6.0

  • Adjusted the shadow in EuiComment (#4321)
  • Added success and warning colors to EuiButtonEmpty (#4325)
  • Added a sorting indicator on the EuiDataGridColumn (#4343)
  • Added disabled and loading status to EuiStep (#4338)
  • Added closePopover prop to EuiDataGridColumnCellActionProps (#4346)

Bug fixes

  • Fixed EuiErrorBoundary error message not showing in non-Chromium browsers (#4324)
  • Fixed EuiToolTip closing during initial positioning period (#4327)
  • Added !default to SASS variables of EuiCollapsibleNav (#4335)
  • Fixed EuiDataGrid column property displayAsText (#4351)
  • Fixed propagation of esc key presses closing parent popovers (#4336)
  • Fixed overwritten isDisabled prop on EuiListGroupItem extraAction config (#4359)
  • Fixed inputRef for EuiCheckbox (#4298)
  • Limited the links allowed in EuiMarkdownEditor to http, https, or starting with a forward slash (#4362)
  • Aligned components with an href prop to React's practice of disallowing javascript: protocols (#4362)
  • Fixed form submit bug in EuiButtonGroup by adding an optional type prop for EuiButtonGroupOption (#4368)

Theme: Amsterdam

  • Removed the shadow in EuiComment (#4321)
  • Reduced font size for xs size in EuiButtonEmpty (#4325)
  • Increased font size for m size of EuiListGroupItem (#4340)
  • Reduced padding in EuiToolTip (#4353)
  • Reduced border-radius in EuiRange's tooltip (#4353)
  • Consolidated EuiStepNumber indicators for EuiSteps and EuiHorizontalSteps (#4338)

@chandlerprall chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.11.0 labels Dec 10, 2020
@chandlerprall chandlerprall marked this pull request as ready for review December 10, 2020 15:39
@chandlerprall chandlerprall requested review from a team as code owners December 10, 2020 15:39
@chandlerprall chandlerprall requested a review from a team December 10, 2020 15:39
@chandlerprall chandlerprall requested review from a team as code owners December 10, 2020 15:39
@chandlerprall chandlerprall requested a review from a team December 10, 2020 15:39
@chandlerprall chandlerprall requested a review from a team as a code owner December 10, 2020 15:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Dec 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

jportner
jportner approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security change (snapshot change) LGTM

cjcenizal
cjcenizal approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES UI snapshot changes LGTM.

chrisronline
chrisronline approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Stack Monitoring!

smith
smith approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes look good!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.3MB 8.3MB +288.0B

Distributable file count

id before after diff
default 47138 47948 +810
Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
css 667.1KB 667.1KB -29.0B
[email protected] 2.4MB 2.5MB +2.7KB
kbn-ui-shared-deps.js 7.0MB 7.0MB +4.4KB
total +7.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chandlerprall chandlerprall merged commit 84d7b9e into elastic:master Dec 14, 2020
@chandlerprall chandlerprall deleted the eui-30-6-0 branch December 14, 2020 22:18
@chandlerprall chandlerprall mentioned this pull request Dec 14, 2020
Merged
chandlerprall added a commit to chandlerprall/kibana that referenced this pull request Dec 14, 2020
@chandlerprall
Upgrade EUI to v30.6.0 and update jest snapshots (elastic#85504)
2e6c663
stratoula pushed a commit that referenced this pull request Dec 15, 2020
@chandlerprall @kibanamachine
Upgrade EUI to v30.6.0 and update jest snapshots (#85504) (#85881)
689cb12 
Co-authored-by: Kibana Machine <[email protected]>
@Dosant Dosant mentioned this pull request Jan 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

@myasonik myasonik myasonik approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@chrisronline chrisronline chrisronline approved these changes

@smith smith smith approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@chandlerprall @elasticmachine @kibanamachine @smith @chrisronline @cjcenizal @pgayvallet @shahzad31 @myasonik @jportner