Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Use displayAsText for column sort search and columns headers #4351

Merged
merged 3 commits into from
Dec 4, 2020
Merged

[EuiDataGrid] Use displayAsText for column sort search and columns headers #4351

merged 3 commits into from
Dec 4, 2020

Conversation

j-m
Copy link
Contributor

@j-m j-m commented Dec 4, 2020

Summary

Before

before

After

after

Checklist

Other than changelog, I don't think any of these apply; I thought I'd wait for a review before editting the changelog. Should I add a test or two?

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

j-m added 2 commits December 4, 2020 19:53
If the `display` property isn't provided, then the column header should use the `displayAsText` property before falling back to `id`.
Docs example now shows `Email address` while keeping `email` id, and other columns now capitalised.
Still uses `id` if `displayAsText` property not provided
@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Dec 4, 2020

💚 CLA has been signed

@j-m
Copy link
Contributor Author

j-m commented Dec 4, 2020

Regarding the CLA, I did this in my free time but in future I may contribute during work hours with this account. I shall sign the individual contributor agreement for now, as work may want me to use a different account anyway, but it may be worth adding an email field alongside the github username.

@j-m j-m changed the title [EuiDataGrid] display as text sort search and headers [EuiDataGrid] Use displayAsText for column sort search and columns headers Dec 4, 2020
@snide
Copy link
Contributor

snide commented Dec 4, 2020

jenkins test this

@snide
Copy link
Contributor

snide commented Dec 4, 2020

@j-m Thanks for the PR. A quick glance and your changes look good. You'll want to add a changelog for this. Here's a suggestion.

- Changed `EuiDataGrid` to display and search against `displayAsText` in the columns popover when provided instead of `id`  `EuiTreeViewNode` ([#4351](https://github.com/elastic/eui/pull/4351))

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4351/

@snide snide merged commit 1748f90 into elastic:master Dec 4, 2020
@snide
Copy link
Contributor

snide commented Dec 4, 2020

Thanks for the PR!

@j-m
Copy link
Contributor Author

j-m commented Dec 4, 2020

Wow that was quick, you're very welcome!

@j-m j-m deleted the datagrid-displayAsText-sort-search-and-headers branch December 4, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants