-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Use displayAsText
for column sort search and columns headers
#4351
[EuiDataGrid] Use displayAsText
for column sort search and columns headers
#4351
Conversation
If the `display` property isn't provided, then the column header should use the `displayAsText` property before falling back to `id`. Docs example now shows `Email address` while keeping `email` id, and other columns now capitalised.
Still uses `id` if `displayAsText` property not provided
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
Regarding the CLA, I did this in my free time but in future I may contribute during work hours with this account. I shall sign the individual contributor agreement for now, as work may want me to use a different account anyway, but it may be worth adding an email field alongside the github username. |
displayAsText
for column sort search and columns headers
jenkins test this |
@j-m Thanks for the PR. A quick glance and your changes look good. You'll want to add a changelog for this. Here's a suggestion.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4351/ |
Thanks for the PR! |
Wow that was quick, you're very welcome! |
Summary
displayAsText
column prop as a heading ([EuiDataGrid]displayAsText
not setting column names #4114). Will usedisplay
overdisplayAsText
, anddisplayAsText
overid
.displayAsText
column prop ([EuiDataGrid] Columns search does not match display text #4204). Will still useid
ifdisplayAsText
was not provided.Before
After
Checklist
Other than changelog, I don't think any of these apply; I thought I'd wait for a review before editting the changelog. Should I add a test or two?