Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] displayAsText not setting column names #4114

Closed
j-m opened this issue Oct 6, 2020 · 3 comments
Closed

[EuiDataGrid] displayAsText not setting column names #4114

j-m opened this issue Oct 6, 2020 · 3 comments
Labels
data grid

Comments

@j-m
Copy link
Contributor

j-m commented Oct 6, 2020

The column names appear to only use the column's id, ignoring the displayAsText prop. The visible columns selection menu correctly shows the displayAsText prop instead of id. There are several examples in the docs that also use the displayAsText prop but show id.

image
@j-m
Copy link
Contributor Author

j-m commented Oct 6, 2020

As a workaround I am just changing the ids. Bit annoying seeing as they contain spaces which means I have to, heaven forbid, use syntax like row['Project Label'] instead of row.label

@j-m j-m mentioned this issue Oct 30, 2020
Closed
@j-m
Copy link
Contributor Author

j-m commented Dec 4, 2020

I will attempt to fix this
If I spot a solution to #4204 I will fix that in the same PR

@j-m j-m mentioned this issue Dec 4, 2020
Merged
10 tasks
snide pushed a commit that referenced this issue Dec 4, 2020
@j-m
[EuiDataGrid] Use displayAsText for column sort search and columns …
1748f90 
…headers (#4351)

* Column headers use displayAsText (#4114)

If the `display` property isn't provided, then the column header should use the `displayAsText` property before falling back to `id`.
Docs example now shows `Email address` while keeping `email` id, and other columns now capitalised.

* Column search matches `displayAsText` (#4204)

Still uses `id` if `displayAsText` property not provided

* Added `displayAsText` changes to changelog
@snide
Copy link
Contributor

snide commented Dec 4, 2020

Closed via #4351

@snide snide closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data grid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@snide @cchaos @thompsongl @j-m