Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] Columns search does not match display text #4204

Closed
PhaedrusTheGreek opened this issue Oct 30, 2020 · 2 comments
Closed

[EuiDataGrid] Columns search does not match display text #4204

PhaedrusTheGreek opened this issue Oct 30, 2020 · 2 comments
Labels
bug data grid

Comments

@PhaedrusTheGreek
Copy link
Contributor

Column displayAsText is defined, e.g.:

id: 'my_field',
displayAsText: "This is my human readable text"

Columns search box only matches the id, which doesn't make sense since displayAsText is shown below the search box.
@cchaos cchaos changed the title [DataGrid] Columns search does not match DisplayText [EuiDataGrid] Columns search does not match display text Oct 30, 2020
@j-m
Copy link
Contributor

j-m commented Oct 30, 2020

See also #4114

This was referenced Dec 4, 2020
Closed
Merged
snide pushed a commit that referenced this issue Dec 4, 2020
@j-m
[EuiDataGrid] Use displayAsText for column sort search and columns …
1748f90 
…headers (#4351)

* Column headers use displayAsText (#4114)

If the `display` property isn't provided, then the column header should use the `displayAsText` property before falling back to `id`.
Docs example now shows `Email address` while keeping `email` id, and other columns now capitalised.

* Column search matches `displayAsText` (#4204)

Still uses `id` if `displayAsText` property not provided

* Added `displayAsText` changes to changelog
@snide
Copy link
Contributor

snide commented Dec 4, 2020

Closed via #4351

@snide snide closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug data grid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snide @PhaedrusTheGreek @j-m