Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Send to background indicator flaky tooltip #84652

Closed
Dosant opened this issue Dec 1, 2020 · 7 comments
Closed

[Search] Send to background indicator flaky tooltip #84652

Dosant opened this issue Dec 1, 2020 · 7 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana

Comments

@Dosant
Copy link
Contributor

Dosant commented Dec 1, 2020

Kibana version: master

Elasticsearch version:

Server OS version:

Browser version: Chrome 86

Describe the bug:

We are working on Send to background functionality and progress is available in Kibana behind feature flag

xpack.data_enhanced.search.sendToBackground.enabled: true
data.search.aggs.shardDelay.enabled: true # helpful to create "slow" visualizations

Part of this feature is session indicator which appears in the last breadcrumb (currently only in Discover and Dashboard).

In some state EuiTooltip is going crazy when hovering that indicator. it appears and disappears.

Steps to reproduce:

  1. xpack.data_enhanced.search.sendToBackground.enabled: true in kibana.yml
  2. go to discover, send session to background, using session indicator
  3. hover over indicator and see it disappears immediately

Expected behavior:

Tooltip works as expected

Screenshots (if relevant):

Any additional context:

I tried to reproduce in isolation as eui bug, but didn't ... https://codesandbox.io/s/adoring-fog-1g97f?file=/index.js

In Kibana I noticed that tooltip is closed because mouse out event is fired and event.relatedTarget is a tooltip popover element. I suspect it could be related to default tooltip position: https://github.com/elastic/eui/blob/master/src/components/tool_tip/tool_tip.tsx#L73 which with long tooltip text would overlap background session indicator in kibana. This might be what is causing mouse out event in kibana. But I don't know why I can't reproduce it in codesanbox.

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana Team:AppServices labels Dec 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@Dosant Dosant mentioned this issue Dec 1, 2020
38 tasks
@Dosant
Copy link
Contributor Author

Dosant commented Dec 1, 2020

@chandlerprall & @thompsongl, I saw that you had recent commits around tooltip in eui. Maybe you would have an idea what could have go wrong here? I'd open an eui bug, but I wasn't able to reproduce in code sandbox in isolation :(

@Dosant Dosant self-assigned this Dec 1, 2020
@thompsongl
Copy link
Contributor

long tooltip text would overlap background session indicator in kibana.

This does appear to have an impact. The tooltip text changing from "Results loaded" to "Results loaded loaded in the background" likely shifts the tooltip popover into the hover area. Changing "Results loaded loaded in the background" to something shorter prevents the flicker.

I'm still working on a reproduction in a simpler environment, but I have a solution based on modifying bundled EUI code in Kibana. This is something we'll want to address in EUI, so I'll open an issue/PR there when I have a repro.

@thompsongl
Copy link
Contributor

Is this feature targeting release in 7.11, @Dosant?

@Dosant
Copy link
Contributor Author

Dosant commented Dec 2, 2020

Is this feature targeting release in 7.11

@thompsongl, No, so no rush.
Thanks for looking!

@thompsongl
Copy link
Contributor

Fixed in elastic/eui#4327. It'll be a couple weeks before you see it in Kibana due to upgrade timelines.

@Dosant
Copy link
Contributor Author

Dosant commented Jan 6, 2021

Closed by #85504

@Dosant Dosant closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana
Projects
None yet
Development

No branches or pull requests

3 participants