Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiCheckbox] fix inputRef prop on input element #4298

Merged
merged 7 commits into from
Dec 9, 2020
Merged

[EuiCheckbox] fix inputRef prop on input element #4298

merged 7 commits into from
Dec 9, 2020

Conversation

rosko
Copy link
Contributor

@rosko rosko commented Nov 21, 2020 •
edited
Loading

Summary

Fixes the following warning: "React does not recognize the inputRef prop on a DOM element."

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@rosko
[EuiCheckbox] fix inputRef prop on input element
4c7b1a7 
Fixes the following warning: "React does not recognize the `inputRef` prop on a DOM element."
@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Nov 21, 2020 •
edited
Loading

💚 CLA has been signed

@thompsongl
Copy link
Contributor

Hey, thanks, @rosko!

Can you please sign the Contributor agreement using the email associated with your GitHub account?

@rosko
Copy link
Contributor Author

rosko commented Nov 23, 2020

@thompsongl Strange, I signed it two days ago. And, just in case, signed it right now again. I hope it will help.

@thompsongl
Copy link
Contributor

Thanks, @rosko. The CLA checker marked it as signed this time 👍

thompsongl
thompsongl suggested changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things for sake of clarity.
You'll also need to add a changelog entry under the "Bugfixes" section

src/components/form/checkbox/checkbox.tsx Outdated Show resolved Hide resolved
rosko added 5 commits December 9, 2020 15:00
@rosko
[EuiCheckbox] fix inputRef prop on input element
f99cc01 
Fixes the following warning: "React does not recognize the `inputRef` prop on a DOM element."
@rosko
Merge pull request #1 from elastic/master
d8e98c0 
update
@rosko
Merge remote-tracking branch 'origin/master'
4d6ded3
@rosko
Merge branch 'master' into patch-2
b009061 
# Conflicts:
#	CHANGELOG.md
@rosko
[EuiCheckbox] fix inputRef prop on input element
2ddb91c 
Fixes the following warning: "React does not recognize the `inputRef` prop on a DOM element."
@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4298/

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4298/

@thompsongl thompsongl merged commit 90a0280 into elastic:master Dec 9, 2020
@chandlerprall chandlerprall mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosko @kibanamachine @thompsongl