[EuiCheckbox] fix inputRef prop on input element (#4298)

* [EuiCheckbox] fix inputRef prop on input element Fixes the following warning: "React does not recognize the `inputRef` prop on a DOM element." * [EuiCheckbox] fix inputRef prop on input element Fixes the following warning: "React does not recognize the `inputRef` prop on a DOM element." * [EuiCheckbox] fix inputRef prop on input element Fixes the following warning: "React does not recognize the `inputRef` prop on a DOM element." Co-authored-by: Greg Thompson <[email protected]>
elastic · Dec 9, 2020 · 90a0280 · 90a0280
1 parent a019e8c
commit 90a0280
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,7 +14,7 @@
 - Fixed `EuiDataGrid` column property `displayAsText`. Column headers prefer `displayAsText` over `id`; `display` still takes precedence. If provided, the filter in the sort-popover will search against `displayAsText` instead of `id`. ([#4351](https://github.com/elastic/eui/pull/4351))
 - Fixed propagation of `esc` key presses closing parent popovers ([#4336](https://github.com/elastic/eui/pull/4336))
 - Fixed overwritten `isDisabled` prop on `EuiListGroupItem` `extraAction` config ([#4359](https://github.com/elastic/eui/pull/4359))
-
+- Fixed `inputRef` for `EuiCheckbox` ([#4298](https://github.com/elastic/eui/pull/4298))
 
 **Theme: Amsterdam**
 

diff --git a/src/components/form/checkbox/checkbox.tsx b/src/components/form/checkbox/checkbox.tsx
@@ -80,11 +80,11 @@ export class EuiCheckbox extends Component<EuiCheckboxProps> {
       type,
       disabled,
       compressed,
+      indeterminate,
+      inputRef,
       ...rest
     } = this.props;
 
-    const { indeterminate, ...inputProps } = rest; // `indeterminate` is set dynamically later
-
     const classes = classNames(
       'euiCheckbox',
       type && typeToClassNameMap[type],
@@ -115,7 +115,7 @@ export class EuiCheckbox extends Component<EuiCheckboxProps> {
           onChange={onChange}
           disabled={disabled}
           ref={this.setInputRef}
-          {...inputProps}
+          {...rest}
         />
 
         <div className="euiCheckbox__square" />