Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add !default to all EuiCollapsibleNav SASS variables #4335

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Add !default to all EuiCollapsibleNav SASS variables #4335

merged 2 commits into from
Dec 3, 2020

Conversation

GautierT
Copy link
Contributor

@GautierT GautierT commented Dec 3, 2020 •
edited
Loading

Allow for overriding collapsible nav SASS vars. Fixes #4334

Checklist

  • [ ] Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • [ ] Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Dec 3, 2020 •
edited
Loading

💚 CLA has been signed

@GautierT GautierT mentioned this pull request Dec 3, 2020
Closed
cchaos
cchaos reviewed Dec 3, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for the PR @GautierT !

I've added back in our checklist of items to your PR summary. Luckily, this is a pretty simple one so most items I've crossed off. The only other item this PR will need is a Changelog entry. Something like

Added default! to SASS variables of EuiCollapsibleNav

But the changes themselves look good!

GautierT added a commit to GautierT/eui that referenced this pull request Dec 3, 2020
@GautierT
Update CHANGELOG.md to reflect changes on elastic#4335
f26cade
@GautierT GautierT mentioned this pull request Dec 3, 2020
Closed
@GautierT
Copy link
Contributor Author

GautierT commented Dec 3, 2020

Hum i think i created an other PR to add this PR to changelog. #recursion

@GautierT GautierT closed this Dec 3, 2020
@GautierT GautierT reopened this Dec 3, 2020
@cchaos cchaos changed the title Add !default to all collapsible_nav variables Add !default to all EuiCollapsibleNav SASS variables Dec 3, 2020
cchaos
cchaos approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge on CI passing.

Jenkins, test this

@cchaos
Copy link
Contributor

cchaos commented Dec 3, 2020

Jenkins, test this

@GautierT
Copy link
Contributor Author

GautierT commented Dec 3, 2020

Thanks and sorry for the mess !

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4335/

@cchaos cchaos merged commit c72ccd9 into elastic:master Dec 3, 2020
@chandlerprall chandlerprall mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to overrides $euiCollapsibleNavWidth ?
3 participants
@GautierT @kibanamachine @cchaos