Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to overrides $euiCollapsibleNavWidth ? #4334

Closed
GautierT opened this issue Dec 3, 2020 · 2 comments · Fixed by #4335
Closed

How to overrides $euiCollapsibleNavWidth ? #4334

GautierT opened this issue Dec 3, 2020 · 2 comments · Fixed by #4335
Labels

Comments

@GautierT
Copy link
Contributor

GautierT commented Dec 3, 2020

Hi,

I would like to have a bigger sidenavbar.
I was thinking that changing $euiCollapsibleNavWidth in my index.scss like this will work but no...

index.scss imported in index.js with import "./index.scss"

$euiCollapsibleNavWidth: 450px;

@import "@elastic/eui/src/theme_amsterdam_light.scss";

Just to verify my config, if i change $euiSize: 20px; it's working (but i don't want to change it).
but not when i change $euiCollapsibleNavWidth.

What should i do ?

Thanks.

@cchaos
Copy link
Contributor

cchaos commented Dec 3, 2020

Thanks @GautierT , yep it looks like we forgot to add !default to all the collapsible nav variables. We got some other updates in the works for this component and will add this to the list. Or if you feel so inclined, feel free to make a PR!

@GautierT
Copy link
Contributor Author

GautierT commented Dec 3, 2020

Thanks !

i don't really know sass so i didn't know about this. I just created a PR. I think it's the same problem for a lot of components !

Fixed by #4335

@GautierT GautierT closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants