Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to EUI v22.3.0 #62963

Merged
merged 14 commits into from
Apr 22, 2020
Merged

Upgrade to EUI v22.3.0 #62963

merged 14 commits into from
Apr 22, 2020

Conversation

chandlerprall
Copy link
Contributor

Summary

22.3.0

  • Removed dependency on option list for custom option of EuiComboBox (#3183)
  • Fixed EuiPopover arrow position in Android and Linux (#3188)
  • Improved htmlIdGenerator when supplying both prefix and suffix (#3076)
  • Updated pagination prop descriptions for EuiInMemoryTable (#3142)
  • Added title and aria attributes to EuiToken's icon element (#3195)
  • Added new Elasticsearch token types (#2758)

Bug Fixes

  • Fixed bug in EuiAccordion to adjust to the correct height when content height changes (#3160)
  • Fixed bug in EuiBasicTable to handle dynamic icon value properly in collapsed actions (#3145)
  • Fixed availability check for actions in EuiBasicTable (3030)

22.2.0

  • Improved EuiModal close button position to prevent from overlapping with the title (#3176)

Bug Fixes

Feature: EuiCollapsibleNav (#3019)

  • Added EuiCollapsibleNav and EuiCollapsibleNavGroup components
  • Added EuiPinnableListGroup, an extension of EuiListGroup
  • Added ghost colored EuiListGroupItem, increased overall large size, and fixed focus states
  • Added color and size props to EuiListGroup
  • Added home and menu glyphs to EuiIcon
  • Added simple euiXScroll and euiYScroll SASS mixins and CSS utility equivelants

Bug Fixes

  • Fixed EuiAccordion icon margins, focus state, and flex issue in IE
  • Fixed 1.1px height of EuiHorizontalRule

22.1.1

Bug Fixes

  • Fixed infinite call stack in EuiResizeObserver's fallback polyfill (#3180)
  • Correct defaultProps definition in EuiComboBox (#3180)

22.1.0

  • Added delimiter prop to EuiComboBox (#3104)
  • Added useColorPickerState and useColorStopsState utilities (#3067)
  • Fixed EuiSearchBar related types (#3147)
  • Added prepend and append ability to EuiSuperSelect (#3167)

Bug Fixes

  • Fixed EuiNavDrawer scrolling issue on mobile (#3174)

22.0.0

  • Replaced various lodash functions with native functions (#3053)
  • Added whiteSpace prop to EuiCodeBlock (#3103)
  • Added sortMatchesBy prop for EuiComboBox (#3089)
  • Added prepend and append ability to EuiFieldPassword (#3122)
  • Added Enter key press functionality to EuiSuperDatePicker (#3048)
  • Added title to headers of EuiTable in case of truncation (#3094)
  • Added i18n to EuiTableHeaderCell (#3094)
  • Added number and string to size type of EuiImage for setting custom sizes (#3012)
  • Improved EuiButtonEmpty focus state when the color type is text (#3135)
  • Added EuiLoadingElastic component (#3017)
  • Upgraded react-beautiful-dnd to v13 (#3064)
  • Fixed EuiPagination vertical alignment of the text when used as compressed (#3152)
  • Added showTooltip prop for EuiSuperUpdateButton to show tooltip and showing only once popovers are closed (#3127)

Bug Fixes

  • Fixed bug in EuiSuperDatePicker not showing correct values in relative tab of end date (#3132)
  • Fixed bug in EuiSuperDatePicker to show correct values of commonly used values in relative tab (#3106)
  • Fixed race condition in EuiIcon when switching from dynamically fetched components (#3118)
  • Fixed the issue that EuiResizeObserver fallback did not properly listen to pure window resizing (#3088)

Breaking changes

  • Removed EuiKeyPadMenuItemButton in favor of just EuiKeyPadMenuItem that can also accept an onClick (#3062)

21.1.0

  • Updated EuiFilterSelect to retain the order of its filters (#3063)
  • Added href prop to EuiBadge (#3009)
  • Added props descriptions for EuiComboBox (#3007)
  • Exported dateFormatAliases as a part of the public API (#3043)
  • Exported EuiTextProps type definition (#3039)
  • Added a component prop to EuiForm to render a <form>(#3010)
  • Removed role attribute from EuiImage(#3036)
  • Added prepend and append ability to EuiComboBox single selection only (#3003)
  • Added onColumnResize prop to EuiDataGrid of type EuiDataGridOnColumnResizeHandler that gets called when column changes it's size (#2963)
  • Added logoEnterpriseSearch to EuiIcon (#3066)
  • Added RGB format support to EuiColorPicker and EuiColorStops (#2850)
  • Added alpha channel (opacity) support to EuiColorPicker and EuiColorStops (#2850)
  • Added useResizeObserver hook (#2991)
  • Added showColumnSelector.allowHide and showColumnSelector.allowReorder props to EuiDataGrid UI configuration (#2993)
  • Added EuiMark component (#3060)
  • Changed tabs.name prop shape in EuiTabbedContent to accept a node, which aligns it with EuiTab (#3100)

Bug Fixes

@chandlerprall chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 8, 2020
@chandlerprall chandlerprall mentioned this pull request Apr 8, 2020
Closed
@chandlerprall
Copy link
Contributor Author

xpack-siemCypress test is failing due to yarn's installation of workspace dependencies. @spalger is investigating (❤️)

@chandlerprall chandlerprall force-pushed the eui-22-3-0 branch 2 times, most recently from d5d7267 to f126ee8 Compare April 15, 2020 17:07
@chandlerprall chandlerprall marked this pull request as ready for review April 16, 2020 21:32
@chandlerprall chandlerprall requested review from a team as code owners April 16, 2020 21:32
@chandlerprall chandlerprall requested a review from a team April 16, 2020 21:32
@chandlerprall chandlerprall requested review from a team as code owners April 16, 2020 21:32
@chandlerprall chandlerprall requested a review from a team April 16, 2020 21:32
legrego
legrego approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM - code review only

spalger
spalger approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operations: LGTM

pgayvallet
pgayvallet approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for platform changes

...aved_objects_management/public/management_section/objects_table/components/relationships.tsx Outdated Show resolved Hide resolved
mikecote
mikecote approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting code LGTM

chrisronline
chrisronline approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes for the monitoring plugin

poffdeluxe
poffdeluxe suggested changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a few errors when loading up Canvas that aren't present on master. Chrome logs an error to console and Firefox throws up a caught error message in the Canvas app. The logged error isn't super helpful cuz it's throwing the error that's happening while handling a different error.

The error it's trying to handle is ResizeObserver loop limit exceeded

poffdeluxe
poffdeluxe approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas changes lgtm!

smith
smith approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes look ok.

...p/TransactionDetails/WaterfallWithSummmary/WaterfallContainer/Waterfall/SpanFlyout/index.tsx Show resolved Hide resolved
lizozom
lizozom reviewed Apr 19, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elastic elastic deleted a comment from elasticmachine Apr 19, 2020
peteharverson
peteharverson approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML LGTM - also gave it a quick visual test locally.

@chandlerprall
Copy link
Contributor Author

jenkins test this

@rylnd rylnd mentioned this pull request Apr 21, 2020
Closed
rylnd
rylnd approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIEM changes LGTM. Sorry about the snapshot noise! A followup on the as anys would be appreciated as well, but I understand the limitations are between EUI and styled-components.

...cy/plugins/siem/public/components/notes/note_card/__snapshots__/note_card_body.test.tsx.snap Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chandlerprall chandlerprall merged commit 126d187 into elastic:master Apr 22, 2020
@chandlerprall chandlerprall deleted the eui-22-3-0 branch April 22, 2020 17:02
@chandlerprall chandlerprall mentioned this pull request Apr 22, 2020
Merged
chandlerprall added a commit that referenced this pull request Apr 22, 2020
@chandlerprall
Upgrade to EUI v22.3.0 (#62963) (#64222)
43cba29 
* snapshot updates

* bump to eui 22.3.0

* snapshots

* Fix css selector in test to match EUI internal DOM change

* Updated snapshots

* Insert react-beautiful-dnd@10 into top-level kibana to force siem's node_modules to hold its correct version

* More snapshot updates, resolved a typescript issue

* Move react-beautiful-dnd dependency around to make things happy again

* Use SearchFilterConfig from the top-level eui export

* Swallow 'ResizeObserver error does not have an err object' error in canvas

* Swallow ResizeObserver error cross-browser
@rylnd rylnd mentioned this pull request Apr 22, 2020
Merged
4 tasks
@chandlerprall chandlerprall mentioned this pull request Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@mikecote mikecote mikecote approved these changes

@legrego legrego legrego approved these changes

@lizozom lizozom lizozom approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@spalger spalger spalger approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@rylnd rylnd rylnd approved these changes

@chrisronline chrisronline chrisronline approved these changes

@smith smith smith approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.