Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automated a11y tests for some docs pages #3036

Merged
merged 17 commits into from
Mar 11, 2020
Merged

Conversation

anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented Mar 10, 2020

Summary

Makes progress on #2679
Automated Axe testing

Layout

  • Horizontal Rule
  • Modal
  • Nav Drawer
  • Panel
  • Popover
  • Spacer

Navigation

  • Breadcrumbs
  • Context Menu
  • Control Bar
  • Link
  • Pagination
  • Steps
  • Tabs

Display

  • Avatar
  • Badge
  • Callout
  • Card
  • Description List
  • EmptyPrompt
  • Health
  • Icons
  • List Group
  • Stat
  • Text
  • Title
  • Toast
  • ToolTip

Forms

  • Form validation
  • Code Editor
  • Expression
  • Search Bar

Elastic Charts

  • Sizing
  • Time series
  • Categorical

Utilities

  • I18n
  • Is Color Dark
  • Pretty Duration
  • MutationObserver
  • Outside Click Detector
  • Portal
  • ResizeObserver
  • Responsive
  • Toggle
  • Window Events

Package

  • I18n Tokens

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests
- [ ] Checked for breaking changes and labeled appropriately

  • Checked for accessibility including keyboard-only and screenreader modes
    - [ ] A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS PR IS AWESOME!!!!!!!!!

src-docs/src/views/i18n/i18n_renderprop.js Outdated Show resolved Hide resolved
src-docs/src/views/tool_tip/tool_tip.js Show resolved Hide resolved
@anishagg17
Copy link
Contributor Author

anishagg17 commented Mar 10, 2020

@myasonik is there any shortcut to add all entries in a pr description #3036 (comment)

@anishagg17 anishagg17 mentioned this pull request Mar 10, 2020
1 task
@myasonik
Copy link
Contributor

is there any shortcut to add all entries in a pr description

I'm not sure what you mean...

@anishagg17
Copy link
Contributor Author

anishagg17 commented Mar 10, 2020

do we have to add every entry in the list manually

such as

Navigation

  • Control Bar
  • Link
  • Pagination
  • Steps
  • Tabs

or is there any shortcut to add all of them

@myasonik
Copy link
Contributor

Oh! In PR descriptions? No. I can figure that out based on the array being added to the test suite and I am keeping #2679 up to date myself so you don't need to worry about that either.

@myasonik
Copy link
Contributor

jenkins test this

@myasonik
Copy link
Contributor

@anishagg17 If you do more work on adding new pages, can you open a new PR? Just to keep these a little smaller. Thanks!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3036/

src/components/image/image.tsx Show resolved Hide resolved
@cchaos
Copy link
Contributor

cchaos commented Mar 11, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3036/

src-docs/src/components/guide_page/guide_page_chrome.js Outdated Show resolved Hide resolved
src-docs/src/views/breadcrumbs/breadcrumbs.js Show resolved Hide resolved
src-docs/src/views/filter_group/filter_group_multi.js Outdated Show resolved Hide resolved
src-docs/src/views/icon/icon_types.js Outdated Show resolved Hide resolved
src-docs/src/views/i18n/i18n_renderprop.js Outdated Show resolved Hide resolved
src-docs/src/views/popover/input_popover.js Outdated Show resolved Hide resolved
src-docs/src/views/steps/steps_complex.js Outdated Show resolved Hide resolved
src-docs/src/views/tool_tip/tool_tip.js Outdated Show resolved Hide resolved
src/components/image/image.tsx Show resolved Hide resolved
@cchaos
Copy link
Contributor

cchaos commented Mar 11, 2020

You'll also need to run the test updates because of the changes to EuiImage. That's why the build is failing.

@cchaos
Copy link
Contributor

cchaos commented Mar 11, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3036/

@cchaos
Copy link
Contributor

cchaos commented Mar 11, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3036/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked through all the changes and made sure nothing broke or errored 👍

@cchaos cchaos changed the title Added automated tests for some pages Added automated a11y tests for some docs pages Mar 11, 2020
@cchaos cchaos merged commit 46a1150 into elastic:master Mar 11, 2020
@anishagg17 anishagg17 deleted the acce branch March 11, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants