-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added automated a11y tests for some docs pages #3036
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THIS PR IS AWESOME!!!!!!!!!
Co-Authored-By: Michail Yasonik <[email protected]>
Co-Authored-By: Michail Yasonik <[email protected]>
@myasonik is there any shortcut to add all entries in a pr description #3036 (comment) |
I'm not sure what you mean... |
do we have to add every entry in the list manually such as Navigation
or is there any shortcut to add all of them |
Oh! In PR descriptions? No. I can figure that out based on the array being added to the test suite and I am keeping #2679 up to date myself so you don't need to worry about that either. |
jenkins test this |
@anishagg17 If you do more work on adding new pages, can you open a new PR? Just to keep these a little smaller. Thanks! |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3036/ |
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3036/ |
You'll also need to run the test updates because of the changes to EuiImage. That's why the build is failing. |
Co-Authored-By: Caroline Horn <[email protected]>
Co-Authored-By: Caroline Horn <[email protected]>
Co-Authored-By: Caroline Horn <[email protected]>
Co-Authored-By: Caroline Horn <[email protected]>
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3036/ |
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3036/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked through all the changes and made sure nothing broke or errored 👍
Summary
Makes progress on #2679
Automated Axe testing
Layout
Navigation
Display
Forms
Elastic Charts
Utilities
Package
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] A changelog entry exists and is marked appropriately