Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta][Docs] Add automated tests for all pages #2679

Closed
16 of 26 tasks
myasonik opened this issue Dec 17, 2019 · 9 comments
Closed
16 of 26 tasks

[Meta][Docs] Add automated tests for all pages #2679

myasonik opened this issue Dec 17, 2019 · 9 comments
Labels
accessibility good first issue testing Issues or PRs that only affect tests - will not need changelog entries

Comments

@myasonik
Copy link
Contributor

myasonik commented Dec 17, 2019

After #2569, the guideline pages could manually be added to run through axe to check for accessibility issues. After #3502, all guidelines pages were tested by default unless they were disabled.

Implementation note: To see the currently skipped pages, go to scripts/a11y-testing.js.

Pages left to enable:

  • Resizable Container
  • Button
  • Tree View
  • Side Nav
  • Tables
  • In Memory Tables
  • Aspect Ratio
  • Code
  • Drag And Drop
  • Compressed Forms
  • Combo Box
  • Color Selection
  • Code Editor
  • Date Picker
  • Selectable (Misc cleanup after resurecting #3570)
  • Suggest
  • Super Date Picker
  • Creating Charts
  • Part to Whole Comparisons
  • CSS Utility Classes
  • Focus Trap
  • Page
  • Page Header
  • Data grid styling & control
  • Data grid virtualization
  • Data grid row heights options

PRs so far:

@myasonik myasonik added accessibility testing Issues or PRs that only affect tests - will not need changelog entries labels Dec 17, 2019
@myasonik myasonik mentioned this issue Dec 17, 2019
4 tasks
@anishagg17
Copy link
Contributor

@myasonik what needs to be done for this?

@myasonik
Copy link
Contributor Author

myasonik commented Mar 6, 2020

@anishagg17, PR #2995 by @ashikmeerankutty is a good example of what needs to be done. (You can find some more examples of the type of work that might need to be done in #2569 though it's a little bit muddled with some setup work that was done as well.)

As this is a big ticket if you're going to work on it please comment on which pages you are working to add. Also, please feel free to add pages non-linearly as it's all controlled by an array of which pages to check. Feel free to push any range of pages onto that array to be tested.

You can find docs on the accessibility testing setup on the wiki.

@anishagg17
Copy link
Contributor

okay @myasonik

@anishagg17
Copy link
Contributor

@myasonik Loading and Progress pass axe testing

@anishagg17
Copy link
Contributor

anishagg17 commented Mar 13, 2020

Please recheck for Layout -> header

@myasonik
Copy link
Contributor Author

Good catch! Removed!

@hetanthakkar
Copy link
Contributor

is anyone working on this issue i would like to. @anishagg17 @myasonik

@myasonik
Copy link
Contributor Author

Hi @hetanthakkar1! This issue is quite large we (mostly @anishagg17) have been merging small PRs as they are ready to be able to make steady progress over time instead of no progress for a long time and then trying to roll out a big bang change.

You can see in the description which pages are already done and you can see open PRs (such as #3077) linked in this thread as well.

We're happy to look at any PRs for pages that aren't currently in progress!

If you're worried about conflicting with work other devs might have locally on their machines but not yet pushed to a PR, feel free to shout out here what pages you are taking on so that others know not to tackle them.

@JasonStoltz JasonStoltz changed the title [Docs] Add automated tests for all pages [Meta][Docs] Add automated tests for all pages Jan 23, 2023
@cee-chen
Copy link
Contributor

Closing this in favor of #6302

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility good first issue testing Issues or PRs that only affect tests - will not need changelog entries
Projects
None yet
Development

No branches or pull requests

5 participants