Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc cleanup after resurecting #3570

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Misc cleanup after resurecting #3570

merged 2 commits into from
Jun 9, 2020

Conversation

myasonik
Copy link
Contributor

@myasonik myasonik commented Jun 5, 2020

Summary

After about a month of neglect, I'm picking this work back up! In that time, a bug appeared (or, it always existed and we never caught it).

This fixes the bug (an extra tab stop in FF). While I was there, I also:

  • added this page to the a11y testing (which required an upgrade to axe)
  • fixed some verbiage on the docs/minor docs bug
  • fixed some bugs with passing through aria attributes

Note: This is targeting a feature branch (#3169)

Checklist

  • Checked in Firefox
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader
    - [ ] Check against all themes for compatibility in both light and dark modes
    - [ ] Checked in mobile
    - [ ] Checked in IE11
    - [ ] Props have proper autodocs
    - [ ] Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
    - [ ] A changelog entry exists and is marked appropriately

@myasonik myasonik added bug accessibility dependencies Pull requests that update a dependency file labels Jun 5, 2020
@myasonik myasonik requested a review from chandlerprall June 5, 2020 21:50
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3570/

1 similar comment
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3570/

chandlerprall
chandlerprall suggested changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small ask, otherwise this looks good

src/components/selectable/selectable_list/selectable_list.tsx Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3570/

@myasonik myasonik requested a review from chandlerprall June 9, 2020 16:56
chandlerprall
chandlerprall approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@myasonik myasonik changed the title Misc cleanup for long running Selectable feature branch Misc cleanup after resurecting Jun 9, 2020
@myasonik myasonik merged commit 3eb02e4 into elastic:feature/selectable-a11y Jun 9, 2020
@myasonik myasonik deleted the selectable-a11y/decrustifying branch June 9, 2020 16:59
This was referenced Jun 9, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
accessibility bug dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myasonik @kibanamachine @chandlerprall