Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/EuiMark #3060

Merged
merged 3 commits into from
Mar 13, 2020
Merged

Feature/EuiMark #3060

merged 3 commits into from
Mar 13, 2020

Conversation

mridulgogia
Copy link
Contributor

Summary

#2085
Added EuiMark component

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@myasonik
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3060/

@thompsongl
Copy link
Contributor

From previously open PRs:

We'll want to add the following for accessibility, also:
https://github.com/thompsongl/eui/blob/euimark/src/components/mark/_mark.scss#L19-L37

@snide
Copy link
Contributor

snide commented Mar 13, 2020

From previously open PRs:

We'll want to add the following for accessibility, also:
https://github.com/thompsongl/eui/blob/euimark/src/components/mark/_mark.scss#L19-L37

I'd suggest doing something similar to this using EuiScreenReaderOnly before and after the mark, rather than using CSS before/after. That was we can make sure the text gets i18n treatment.

@cchaos
Copy link
Contributor

cchaos commented Mar 13, 2020

Lets get this PR in for @mridulgogia and then we can do a follow up for a11y and style.

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3060/

@cchaos cchaos merged commit a8a4063 into elastic:master Mar 13, 2020
@cchaos cchaos mentioned this pull request Mar 13, 2020
3 tasks
Marvin9 added a commit to Marvin9/eui that referenced this pull request Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants