Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit selected value to quick select in EuiSuperDatePicker #3105

Merged
merged 21 commits into from
Mar 26, 2020
Merged

Inherit selected value to quick select in EuiSuperDatePicker #3105

merged 21 commits into from
Mar 26, 2020

Conversation

ashikmeerankutty
Copy link
Contributor

@ashikmeerankutty ashikmeerankutty commented Mar 17, 2020 •
edited
Loading

Summary

Fixes #1597

Inherit selected value to quick select.

Before

before
After

after

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests
- [ ] Checked for breaking changes and labeled appropriately
- [ ] Checked for accessibility including keyboard-only and screenreader modes

  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ashikmeerankutty ashikmeerankutty changed the title Inherit selected value to quick select in EuiSuperDatePicker [WIP] Inherit selected value to quick select in EuiSuperDatePicker Mar 17, 2020
@ashikmeerankutty ashikmeerankutty changed the title [WIP] Inherit selected value to quick select in EuiSuperDatePicker Inherit selected value to quick select in EuiSuperDatePicker Mar 17, 2020
@cchaos
Copy link
Contributor

cchaos commented Mar 19, 2020

Jenkins, test this

@ashikmeerankutty Can you also add a little more description like some before/after screenshots?

@cchaos cchaos requested a review from chandlerprall March 19, 2020 13:00
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3105/

@ashikmeerankutty
Copy link
Contributor Author

@cchaos Thanks for the review, updated the function description and added before and after screenshots. Can you please review it?

@cchaos
Copy link
Contributor

cchaos commented Mar 20, 2020

Jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3105/

cchaos
cchaos reviewed Mar 20, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashikmeerankutty. The behavior seems to work well. I'd suggest adding some tests for the new parseTimeParts() method. And then I'd ask @chandlerprall to review since this is mostly JS.

@chandlerprall
Copy link
Contributor

+1 to some tests; I'll review once those have been added

@ashikmeerankutty
Copy link
Contributor Author

@cchaos @chandlerprall Thanks for the review. Added tests 👍

@chandlerprall
Copy link
Contributor

Relative

This appears to be correct when inheriting relative values

relative

Absolute

and correctly ignores absolute values

absolute

Future

but doesn't react as expected to now -> relative times

now->relative

@ashikmeerankutty
Copy link
Contributor Author

@chandlerprall Fixed 👍

chandlerprall
chandlerprall suggested changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very clean & straight forward! I have some inconsequential code changes, one question, and would like one more unit test.

src/components/date_picker/super_date_picker/quick_select_popover/quick_select_utils.js Outdated Show resolved Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/quick_select_utils.js Outdated Show resolved Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/quick_select_utils.js Outdated Show resolved Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/quick_select_utils.js Show resolved Hide resolved
@chandlerprall
Copy link
Contributor

I resolved the changelog conflict as our releases tend to mess those up in PRs

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3105/

chandlerprall
chandlerprall approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; Pulled & tested locally.

Thanks again @ashikmeerankutty !

@chandlerprall chandlerprall merged commit c495aef into elastic:master Mar 26, 2020
@chandlerprall chandlerprall mentioned this pull request Apr 8, 2020
Merged
@ashikmeerankutty ashikmeerankutty deleted the fix/super-date-picker branch April 15, 2020 09:53
@thompsongl thompsongl mentioned this pull request May 8, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos left review comments

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiSuperDatePicker] Quick select doesn't inherit selected value
4 participants
@ashikmeerankutty @kibanamachine @cchaos @chandlerprall