Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added enter key functionality #3048

Merged
merged 13 commits into from
Mar 17, 2020
Merged

added enter key functionality #3048

merged 13 commits into from
Mar 17, 2020

Conversation

anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented Mar 12, 2020 •
edited
Loading

Summary

Fixes : #3033
added enter key functionality in eui super date picker

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples

  • Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@chandlerprall chandlerprall self-assigned this Mar 12, 2020
chandlerprall
chandlerprall suggested changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as desired; have some feedback on the code changes

src/components/date_picker/super_date_picker/__snapshots__/super_date_picker.test.js.snap Outdated Show resolved Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/quick_select.js Outdated Show resolved Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/quick_select.js Outdated Show resolved Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/refresh_interval.js Outdated Show resolved Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/refresh_interval.js Outdated Show resolved Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/refresh_interval.js Outdated Show resolved Hide resolved
@chandlerprall
Copy link
Contributor

@myasonik can you please review the change of <fieldset> -> <fieldset role="presentation" onKeyDown={this.handleKeyDown}> in both refresh_interval.js and quick_select.js ? See comments in #3048 (comment)

Alternative would be to pass the onKeyDown individually on the inputs, but this grouping at the fieldset seems decent?

@chandlerprall chandlerprall requested a review from myasonik March 16, 2020 17:17
@anishagg17
Copy link
Contributor Author

this function performs the following :

Hnet com-image (7)

@myasonik
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3048/

@anishagg17
Copy link
Contributor Author

All changes have been made

@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3048/

chandlerprall
chandlerprall approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; thanks for iterating on this one @anishagg17 !

@chandlerprall chandlerprall merged commit 5f7f229 into elastic:master Mar 17, 2020
@anishagg17 anishagg17 deleted the enter branch March 17, 2020 19:27
@chandlerprall chandlerprall mentioned this pull request Mar 31, 2020
Closed
@chandlerprall chandlerprall mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philkra philkra philkra left review comments

@philippkahr philippkahr philippkahr left review comments

@chandlerprall chandlerprall chandlerprall approved these changes

@myasonik myasonik Awaiting requested review from myasonik

Assignees

@chandlerprall chandlerprall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discover enter (key) does not trigger start stop on autorefresh
6 participants
@anishagg17 @kibanamachine @chandlerprall @myasonik @philippkahr @philkra