adding feature to remove circles when option to remove circles selected #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@w33ble ok, its ready for review. |
| @@ -105,13 +106,23 @@ define(function (require) { | |||
| return color(d.label); | |||
| } | |||
|
|
|||
| function showColor(d) { | |||
There was a problem hiding this comment.
The name of this method implies that it returns a boolean, but it does not, it returns the color based on the showCircles option.
|
Renaming showColor is the only thing I'd like to see happen here - otherwise this LGTM. |
|
@w33ble put in the function name change. |
w33ble
added a commit
that referenced
this pull request
Mar 4, 2015
adding feature to remove circles when option to remove circles selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3176.
Adds ability to not display circles on line charts.