[kbn/rule-data-utils] add submodules and require public use them #117963

spalger · 2021-11-09T02:05:58Z

Similar to #117958, this adds import targets to @kbn/rule-data-utils so that we can import sub-modules from the package directly without resorting to wacky hacks. Adds the following import targets and imports from there where appropriate:

@kbn/rule-data-utils/alerts_as_data_rbac
@kbn/rule-data-utils/alerts_as_data_severity
@kbn/rule-data-utils/alerts_as_data_status
@kbn/rule-data-utils/technical_field_names

Additionally we've prevented public and common code from importing from @kbn/rule-data-utils directly, to prevent the whole package from ending up in a bundle and bloating it.

elasticmachine · 2021-11-09T21:32:32Z

Pinging @elastic/kibana-operations (Team:Operations)

smith

APM changes look good.

elasticmachine · 2021-11-09T21:50:35Z

Pinging @elastic/apm-ui (Team:apm)

elasticmachine · 2021-11-09T21:50:35Z

Pinging @elastic/uptime (Team:uptime)

dominiqueclarke

Uptime changes LGTM

spalger · 2021-11-10T19:54:36Z

@elasticmachine merge upstream

…ule-data-utils-submodules

spalger · 2021-11-13T18:43:55Z

@elasticmachine merge upstream

FrankHassanabad · 2021-11-15T17:25:54Z

.eslintrc.js

@@ -850,6 +850,10 @@ module.exports = {
                name: 'semver',
                message: 'Please use "semver/*/{function}" instead',
              },
+              {
+                name: '@kbn/rule-data-utils',
+                message: `Import directly from @kbn/rule-data-utils/* submodules in public/common code`,


Is this message specific to rule-data-utils?

Should this read generically like:

Import directly from @kbn/<module_name>/* in public/common code

or

Import directly from @kbn/*/* in public/common code

Yes, this is specific to the @kbn/rule-data-utils package as import targets have to be setup for each package individually

FrankHassanabad · 2021-11-15T17:26:27Z

packages/kbn-rule-data-utils/technical_field_names/package.json

+{
+  "main": "../target_node/technical_field_names",
+  "types": "../target_types/technical_field_names"
+}


nit: surprised your IDE/prettier isn't adding new lines here.

That's what's defined in the .editorconfig file, which is automatically managed by the EditorConfig plugin in IDEs https://github.com/elastic/kibana/blob/main/.editorconfig#L12-L13

FrankHassanabad

Read through the ticket, added two small minor items. This is mergeable anytime.

Zacqary

observability changes look good

…ule-data-utils-submodules

kibana-ci · 2021-11-15T21:29:41Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1183	1181	-2
`cases`	341	337	-4
`infra`	931	927	-4
`observability`	345	343	-2
`securitySolution`	2796	2792	-4
`uptime`	641	638	-3
total			-19

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.7MB	2.7MB	+8.7KB
`cases`	323.9KB	321.9KB	-2.0KB
`infra`	921.6KB	921.6KB	-25.0B
`observability`	381.3KB	389.9KB	+8.7KB
`securitySolution`	4.5MB	4.5MB	-4.0B
`timelines`	207.6KB	209.6KB	+2.0KB
`uptime`	573.3KB	573.3KB	-7.0B
total			+17.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`apm`	29.3KB	29.4KB	+111.0B
`infra`	90.3KB	88.3KB	-2.0KB
`securitySolution`	253.9KB	251.9KB	-2.0KB
`timelines`	168.0KB	166.0KB	-2.0KB
`uptime`	24.9KB	23.1KB	-1.8KB
total			-7.6KB

History

💛 Build #6523 was flaky 0c33955
💚 Build #6415 succeeded 76a1f39
💛 Build #5942 was flaky 7106d9b
💚 Build #5268 succeeded e35993c
💔 Build #5248 failed a709cf8b01bc7f6e8d07fdebaa5df2dbe96659fb
💔 Build #5242 failed fc9d65622529209e63caa7e1b72a9354cf7662fc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…stic#117963) * [kbn/rule-data-utils] add submodules and require public use them * fix lint errors Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-11-15T22:27:43Z

💔 Backport failed

Status	Branch	Result
✅	8.0
❌	7.16	Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 117963

…7963) (#118628) * [kbn/rule-data-utils] add submodules and require public use them * fix lint errors Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Spencer <[email protected]>

…igrate-away-from-injected-css-js * 'main' of github.com:elastic/kibana: (221 commits) [Reporting] Add log level to config (elastic#118319) [Metrics UI] Skip failing waffle chart color palette test (elastic#118527) [APM] chore: Unify naming of 'apm/scripts/**/*' with snake_case (elastic#118328) skip flaky suites (elastic#99581, elastic#118356, elastic#118474) [Alerting] Initial implementation of alerting task `cancel()` (elastic#114289) chore(NA): creates pkg_npm_types bazel rule (elastic#116465) skip flaky suite (elastic#116892) Bump chromedriver to 95.0.0 (elastic#116724) [Data visualizer] Improve design of expanded rows (elastic#118125) [APM] prefer ECS field names for HTTP and URL (elastic#118485) Update query_debugging_in_development_and_production.md (elastic#118491) [Uptime] adjust Elastic Synthetics integration functional tests (elastic#118163) [kbn/rule-data-utils] add submodules and require public use them (elastic#117963) [DOCS] Refresh APM correlation screenshots (elastic#116723) (elastic#118577) Handles ns to ms conversion for event loop delay metrics (elastic#118447) [Cases] Rename functional tests folder (elastic#118490) dummy commit skip flaky suite (elastic#118593) Improve workpad schema validation (elastic#97838) skip flaky suite (elastic#118584) ... # Conflicts: # src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx

…stic#117963) * [kbn/rule-data-utils] add submodules and require public use them * fix lint errors Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/apm/server/lib/alerts/register_transaction_duration_anomaly_alert_type.ts # x-pack/plugins/cases/public/components/user_action_tree/index.tsx # x-pack/plugins/observability/public/pages/alerts/alerts_flyout/index.tsx # x-pack/plugins/security_solution/public/detections/components/alerts_table/actions.tsx # x-pack/plugins/security_solution/public/helpers.ts # x-pack/test/case_api_integration/security_and_spaces/tests/common/cases/patch_cases.ts # x-pack/test/case_api_integration/security_and_spaces/tests/common/comments/post_comment.ts

…7963) (#118725) * [kbn/rule-data-utils] add submodules and require public use them * fix lint errors Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/apm/server/lib/alerts/register_transaction_duration_anomaly_alert_type.ts # x-pack/plugins/cases/public/components/user_action_tree/index.tsx # x-pack/plugins/observability/public/pages/alerts/alerts_flyout/index.tsx # x-pack/plugins/security_solution/public/detections/components/alerts_table/actions.tsx # x-pack/plugins/security_solution/public/helpers.ts # x-pack/test/case_api_integration/security_and_spaces/tests/common/cases/patch_cases.ts # x-pack/test/case_api_integration/security_and_spaces/tests/common/comments/post_comment.ts

…stic#117963) * [kbn/rule-data-utils] add submodules and require public use them * fix lint errors Co-authored-by: Kibana Machine <[email protected]>

…7963) * [kbn/rule-data-utils] add submodules and require public use them * fix lint errors Co-authored-by: Kibana Machine <[email protected]>

spalger added 2 commits November 8, 2021 23:49

[kbn/rule-data-utils] add submodules and require public use them

152e6ae

fix lint errors

e35993c

spalger force-pushed the implement/kbn-rule-data-utils-submodules branch from a709cf8 to e35993c Compare November 9, 2021 06:51

spalger added Team:Operations Team label for Operations Team v7.16.0 v8.0.0 v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Nov 9, 2021

spalger marked this pull request as ready for review November 9, 2021 21:32

spalger requested review from a team as code owners November 9, 2021 21:32

spalger enabled auto-merge (squash) November 9, 2021 21:32

smith approved these changes Nov 9, 2021

View reviewed changes

botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Nov 9, 2021

dominiqueclarke approved these changes Nov 10, 2021

View reviewed changes

Merge branch 'main' into implement/kbn-rule-data-utils-submodules

7106d9b

jbudz approved these changes Nov 10, 2021

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into implement/kbn-r…

76a1f39

…ule-data-utils-submodules

elastic deleted a comment from kibanamachine Nov 11, 2021

Merge branch 'main' into implement/kbn-rule-data-utils-submodules

0c33955

FrankHassanabad reviewed Nov 15, 2021

View reviewed changes

FrankHassanabad approved these changes Nov 15, 2021

View reviewed changes

jasonrhodes requested a review from a team November 15, 2021 17:47

Zacqary approved these changes Nov 15, 2021

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into implement/kbn-r…

b08cdc4

…ule-data-utils-submodules

spalger disabled auto-merge November 15, 2021 22:23

spalger merged commit 0f68fcf into elastic:main Nov 15, 2021

spalger deleted the implement/kbn-rule-data-utils-submodules branch November 15, 2021 22:23

kibanamachine mentioned this pull request Nov 15, 2021

[8.0] [kbn/rule-data-utils] add submodules and require public use them (#117963) #118628

Merged

mgiota requested review from mgiota and removed request for mgiota November 16, 2021 08:17

spalger mentioned this pull request Nov 16, 2021

[7.16] [kbn/rule-data-utils] add submodules and require public use them (#117963) #118725

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[kbn/rule-data-utils] add submodules and require public use them #117963

[kbn/rule-data-utils] add submodules and require public use them #117963

spalger commented Nov 9, 2021 •

edited

Loading

elasticmachine commented Nov 9, 2021

smith left a comment

elasticmachine commented Nov 9, 2021

elasticmachine commented Nov 9, 2021

dominiqueclarke left a comment

spalger commented Nov 10, 2021

spalger commented Nov 13, 2021

FrankHassanabad Nov 15, 2021

spalger Nov 15, 2021

FrankHassanabad Nov 15, 2021

spalger Nov 15, 2021

FrankHassanabad left a comment

Zacqary left a comment

kibana-ci commented Nov 15, 2021

kibanamachine commented Nov 15, 2021

[kbn/rule-data-utils] add submodules and require public use them #117963

[kbn/rule-data-utils] add submodules and require public use them #117963

Conversation

spalger commented Nov 9, 2021 • edited Loading

elasticmachine commented Nov 9, 2021

smith left a comment

Choose a reason for hiding this comment

elasticmachine commented Nov 9, 2021

elasticmachine commented Nov 9, 2021

dominiqueclarke left a comment

Choose a reason for hiding this comment

spalger commented Nov 10, 2021

spalger commented Nov 13, 2021

FrankHassanabad Nov 15, 2021

Choose a reason for hiding this comment

spalger Nov 15, 2021

Choose a reason for hiding this comment

FrankHassanabad Nov 15, 2021

Choose a reason for hiding this comment

spalger Nov 15, 2021

Choose a reason for hiding this comment

FrankHassanabad left a comment

Choose a reason for hiding this comment

Zacqary left a comment

Choose a reason for hiding this comment

kibana-ci commented Nov 15, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

kibanamachine commented Nov 15, 2021

💔 Backport failed

spalger commented Nov 9, 2021 •

edited

Loading