Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.16] [kbn/rule-data-utils] add submodules and require public use them (#117963) #118725

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 16, 2021

Backports the following commits to 7.16:

…stic#117963)

* [kbn/rule-data-utils] add submodules and require public use them

* fix lint errors

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/apm/server/lib/alerts/register_transaction_duration_anomaly_alert_type.ts
#	x-pack/plugins/cases/public/components/user_action_tree/index.tsx
#	x-pack/plugins/observability/public/pages/alerts/alerts_flyout/index.tsx
#	x-pack/plugins/security_solution/public/detections/components/alerts_table/actions.tsx
#	x-pack/plugins/security_solution/public/helpers.ts
#	x-pack/test/case_api_integration/security_and_spaces/tests/common/cases/patch_cases.ts
#	x-pack/test/case_api_integration/security_and_spaces/tests/common/comments/post_comment.ts
@spalger spalger enabled auto-merge (squash) November 16, 2021 16:26
@spalger spalger merged commit 35d476e into elastic:7.16 Nov 16, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1183 1181 -2
infra 937 933 -4
observability 351 349 -2
securitySolution 2738 2734 -4
timelines 302 299 -3
uptime 641 638 -3
total -18

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +8.5KB
infra 933.2KB 933.2KB -25.0B
observability 381.0KB 389.4KB +8.5KB
securitySolution 4.6MB 4.6MB -2.0KB
timelines 235.1KB 228.0KB -7.2KB
uptime 572.7KB 572.7KB -7.0B
total +7.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 29.2KB 29.3KB +111.0B
infra 90.2KB 88.2KB -2.0KB
uptime 24.9KB 23.1KB -1.8KB
total -3.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger deleted the backport/7.16/pr-117963 branch November 16, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants