[APM] prefer ECS field names for HTTP and URL #118485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
added
Team:APM
axw
force-pushed
the
apm-span-http-fields
branch
from
ec1e2ae to
4931c87
Compare
1 task
axw
force-pushed
the
apm-span-http-fields
branch
2 times, most recently
from
3713b0c to
986dc84
Compare
axw
force-pushed
the
apm-span-http-fields
branch
from
986dc84 to
9f75882
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/apm-ui (Team:apm) |
smith
added
release_note:skip
smith
approved these changes
Nov 15, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 15, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Nov 16, 2021
Co-authored-by: Andrew Wilkins <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 16, 2021
…igrate-away-from-injected-css-js * 'main' of github.com:elastic/kibana: (221 commits) [Reporting] Add log level to config (elastic#118319) [Metrics UI] Skip failing waffle chart color palette test (elastic#118527) [APM] chore: Unify naming of 'apm/scripts/**/*' with snake_case (elastic#118328) skip flaky suites (elastic#99581, elastic#118356, elastic#118474) [Alerting] Initial implementation of alerting task `cancel()` (elastic#114289) chore(NA): creates pkg_npm_types bazel rule (elastic#116465) skip flaky suite (elastic#116892) Bump chromedriver to 95.0.0 (elastic#116724) [Data visualizer] Improve design of expanded rows (elastic#118125) [APM] prefer ECS field names for HTTP and URL (elastic#118485) Update query_debugging_in_development_and_production.md (elastic#118491) [Uptime] adjust Elastic Synthetics integration functional tests (elastic#118163) [kbn/rule-data-utils] add submodules and require public use them (elastic#117963) [DOCS] Refresh APM correlation screenshots (elastic#116723) (elastic#118577) Handles ns to ms conversion for event loop delay metrics (elastic#118447) [Cases] Rename functional tests folder (elastic#118490) dummy commit skip flaky suite (elastic#118593) Improve workpad schema validation (elastic#97838) skip flaky suite (elastic#118584) ... # Conflicts: # src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 19, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the span flyout, prefer ECS fields for span HTTP and URL properties. Fall back to the old field names for backwards compatibility with old data.
In 7.14 we started copying
span.http.*fields to their ECS equivalents:http.*andurl*.We continued populating the old names for backwards compatibility, but will cease doing so from 8.0 on.
See also elastic/apm-server#5995
Checklist
- [ ] Unit or functional tests were updated or added to match the most common scenarios(Are there any?)For maintainers