Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] adjust Elastic Synthetics integration functional tests #118163

Merged
merged 3 commits into from
Nov 15, 2021
Merged

[Uptime] adjust Elastic Synthetics integration functional tests #118163

merged 3 commits into from
Nov 15, 2021

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Nov 10, 2021 •
edited
Loading

Summary

Fixes Elastic Synthetics Integration functional tests by updating the expected value.

We recently introduced the __ui key. This updates the tests to account for that key.

Fixes #116980
Fixes #109329
Fixes #109260
Fixes #109466

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke force-pushed the fix/synthetics-functional-tests-fix branch from a4a5362 to 67bd238 Compare November 10, 2021 20:26
@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0 failed-test A test failure on a tracked branch, potentially flaky-test auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Nov 15, 2021
@dominiqueclarke dominiqueclarke marked this pull request as ready for review November 15, 2021 03:42
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner November 15, 2021 03:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke changed the title adjust Elastic Synthetics integration functional tests [Uptime] adjust Elastic Synthetics integration functional tests Nov 15, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Nov 15, 2021
shahzad31
shahzad31 approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@dominiqueclarke dominiqueclarke merged commit 06a1a9f into elastic:main Nov 15, 2021
@dominiqueclarke dominiqueclarke deleted the fix/synthetics-functional-tests-fix branch November 15, 2021 22:45
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 8.0 Commit could not be cherrypicked due to conflicts
❌ 7.16 Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 118163

jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 16, 2021
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/poc-m…
0808a04 
…igrate-away-from-injected-css-js

* 'main' of github.com:elastic/kibana: (221 commits)
  [Reporting] Add log level to config (elastic#118319)
  [Metrics UI] Skip failing waffle chart color palette test (elastic#118527)
  [APM] chore: Unify naming of 'apm/scripts/**/*' with snake_case (elastic#118328)
  skip flaky suites (elastic#99581, elastic#118356, elastic#118474)
  [Alerting] Initial implementation of alerting task `cancel()` (elastic#114289)
  chore(NA): creates pkg_npm_types bazel rule (elastic#116465)
  skip flaky suite (elastic#116892)
  Bump chromedriver to 95.0.0 (elastic#116724)
  [Data visualizer] Improve design of expanded rows (elastic#118125)
  [APM] prefer ECS field names for HTTP and URL (elastic#118485)
  Update query_debugging_in_development_and_production.md (elastic#118491)
  [Uptime] adjust Elastic Synthetics integration functional tests (elastic#118163)
  [kbn/rule-data-utils] add submodules and require public use them (elastic#117963)
  [DOCS] Refresh APM correlation screenshots (elastic#116723) (elastic#118577)
  Handles ns to ms conversion for event loop delay metrics (elastic#118447)
  [Cases] Rename functional tests folder (elastic#118490)
  dummy commit
  skip flaky suite (elastic#118593)
  Improve workpad schema validation (elastic#97838)
  skip flaky suite (elastic#118584)
  ...

# Conflicts:
#	src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 16, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 118163 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 118163 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 118163 or prevent reminders by adding the backport:skip label.

mbondyra pushed a commit to mbondyra/kibana that referenced this pull request Nov 19, 2021
@dominiqueclarke @kibanamachine @mbondyra
[Uptime] adjust Elastic Synthetics integration functional tests (elas…
9d91ca3 
…tic#118163)

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 118163 or prevent reminders by adding the backport:skip label.

@dominiqueclarke dominiqueclarke mentioned this pull request Nov 22, 2021
Merged
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Nov 22, 2021
@dominiqueclarke
[Uptime] adjust Elastic Synthetics integration functional tests (elas…
6fe2acb 
…tic#118163)

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/test/functional/apps/uptime/synthetics_integration.ts
@dominiqueclarke dominiqueclarke mentioned this pull request Nov 22, 2021
Merged
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Nov 22, 2021
@dominiqueclarke
[Uptime] adjust Elastic Synthetics integration functional tests (elas…
487f1c9 
…tic#118163)

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/test/functional/apps/uptime/synthetics_integration.ts
dominiqueclarke added a commit that referenced this pull request Nov 22, 2021
@dominiqueclarke
[Uptime] adjust Elastic Synthetics integration functional tests (#118163
266a5aa 
) (#119306)

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/test/functional/apps/uptime/synthetics_integration.ts
dominiqueclarke added a commit that referenced this pull request Nov 22, 2021
@dominiqueclarke
[Uptime] adjust Elastic Synthetics integration functional tests (#118163
9d27a1d 
) (#119307)

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/test/functional/apps/uptime/synthetics_integration.ts
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 22, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@dominiqueclarke @kibanamachine @dmlemeshko
[Uptime] adjust Elastic Synthetics integration functional tests (#118163
0267ebb 
)

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed failed-test A test failure on a tracked branch, potentially flaky-test release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/synthetics_integration·ts - Uptime app with generated data When on the Synthetics Integration Policy Create Page displays custom UI prevent saving when integration name, url/host, or schedule is missing [test-failed]: Chrome X-Pack UI Functional Tests1.x-pack/test/functional/apps/uptime/synthetics_integration·ts - Uptime app with generated data When on the Synthetics Integration Policy Create Page create new policy allows configuring http advanced options Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/synthetics_integration·ts - Uptime app with generated data When on the Synthetics Integration Policy Create Page create new policy allows saving when user enters a valid integration name and url/host Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/synthetics_integration·ts - Uptime app with generated data When on the Synthetics Integration Policy Create Page displays custom UI should display policy view
5 participants
@dominiqueclarke @elasticmachine @kibana-ci @kibanamachine @shahzad31