Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated bitwise operations between different enum types in WTableWidget #45131

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Jun 4, 2024

PR description:

Fixes the following warnings:

  src/Fireworks/TableWidget/src/FWTableWidget.cc:29:50: warning: bitwise operation between different enumeration types 'ELayoutHints' and 'ETableLayoutHints' is deprecated [-Wdeprecated-enum-enum-conversion]
    29 | static const UInt_t kRowOptions = kLHintsExpandX | kLHintsFillX | kLHintsShrinkX;
      |                                   ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
  src/Fireworks/TableWidget/src/FWTableWidget.cc:30:50: warning: bitwise operation between different enumeration types 'ELayoutHints' and 'ETableLayoutHints' is deprecated [-Wdeprecated-enum-enum-conversion]
    30 | static const UInt_t kColOptions = kLHintsExpandY | kLHintsFillY | kLHintsShrinkY;
      |                                   ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~

PR validation:

Bot tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test for CMSSW_14_1_CPP20_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45131/40471

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • Fireworks/TableWidget (visualization)

@makortel, @Dr15Jones, @alja can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1b681/39692/summary.html
COMMIT: 3a7381d
CMSSW: CMSSW_14_1_CPP20_X_2024-06-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45131/39692/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1b681/39692/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1b681/39692/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoPPSLocalNewT2 had ERRORS

Comparison Summary

Summary:

@alja
Copy link
Contributor

alja commented Jun 4, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

ignore tests-rejected with ib-failure

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ebe68aa into cms-sw:master Jun 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants