-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scram tool clean; support for building stack without an option tool #9218
Conversation
test parameters:
|
A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master. @aandvalenzuela, @smuzaffar, @cmsbuild, @iarspider can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
please test |
onnxruntime.spec
Outdated
@@ -21,7 +19,7 @@ rm -rf ../build; mkdir ../build; cd ../build | |||
USE_CUDA=OFF | |||
%if "%{cmsos}" != "slc7_aarch64" | |||
if [ "%{cuda_gcc_support}" = "true" ] ; then | |||
USE_CUDA=ON | |||
USE_CUDA=%{!?without_cuda:ON} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smuzaffar Sholdn't %{cuda_gcc_support}
evaluate to false
if we don't have cuda?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuda_gcc_support
is when we have cuda i.e. we can run but we do not have a working cuda/gcc combination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and
Lines 259 to 270 in 6a36618
%if 0%{!?without_cuda:1} | |
%define cuda_gcc_support $(\ | |
if [ ! -f %{_tmppath}/cache/cuda_gcc_supported.txt ] ; then \ | |
touch %{_builddir}/cuda_gcc_supported.cu &&\ | |
echo true > %{_builddir}/cuda_gcc_supported.txt &&\ | |
(nvcc -dc %{_builddir}/cuda_gcc_supported.cu -o %{_builddir}/cuda_gcc_supported.cu.o 2>&1 || echo 'unsupported GCC version') > %{_builddir}/cuda_gcc_supported.log &&\ | |
if [ $(grep -i 'unsupported ' %{_builddir}/cuda_gcc_supported.log | wc -l) -gt 0 ] ; then echo false > %{_builddir}/cuda_gcc_supported.txt ; fi;\ | |
mv %{_builddir}/cuda_gcc_supported.txt %{_tmppath}/cache/cuda_gcc_supported.txt ;\ | |
fi; cat %{_tmppath}/cache/cuda_gcc_supported.txt) | |
%else | |
%define cuda_gcc_support false | |
%endif |
cuda_gcc_support
to false
is sw stack is build without cuda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. Will this work in a hypotetical situation where we have CUDA support, but don't build with CUDA (i.e. won't a line USE_CUDA=
, where nothing is assigned to USE_CUDA
, break anything?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the case it will work as USE_CUDA=%{!?without_cuda:ON}
will never be executed when we build without_cuda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is true that in this case USE_CUDA=%{!?without_cuda:ON}
change is not needed as for without_cuda
this blockof code is not executed
Pull request #9218 was updated. |
please test |
-1 Failed Tests: Build BuildI found compilation error when building: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++17 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -shared -Wl,-E -Wl,-z,defs tmp/el8_amd64_gcc12/src/HeterogeneousCore/SonicTriton/src/HeterogeneousCoreSonicTriton/TritonClient.cc.o tmp/el8_amd64_gcc12/src/HeterogeneousCore/SonicTriton/src/HeterogeneousCoreSonicTriton/TritonData.cc.o tmp/el8_amd64_gcc12/src/HeterogeneousCore/SonicTriton/src/HeterogeneousCoreSonicTriton/TritonException.cc.o tmp/el8_amd64_gcc12/src/HeterogeneousCore/SonicTriton/src/HeterogeneousCoreSonicTriton/TritonMemResource.cc.o tmp/el8_amd64_gcc12/src/HeterogeneousCore/SonicTriton/src/HeterogeneousCoreSonicTriton/TritonService.cc.o tmp/el8_amd64_gcc12/src/HeterogeneousCore/SonicTriton/src/HeterogeneousCoreSonicTriton/triton_utils.cc.o -o tmp/el8_amd64_gcc12/src/HeterogeneousCore/SonicTriton/src/HeterogeneousCoreSonicTriton/libHeterogeneousCoreSonicTriton.so -Wl,-E -Wl,--hash-style=gnu -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-06-03-1100/biglib/el8_amd64_gcc12 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-06-03-1100/lib/el8_amd64_gcc12 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-06-03-1100/external/el8_amd64_gcc12/lib -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02840/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-03-1100/biglib/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02840/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-03-1100/lib/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02840/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-06-02-0000/lib/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02840/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-06-02-0000/biglib/el8_amd64_gcc12 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/cuda/12.4.1-fc5cb0e72dba64b6abbf00089f3a044c/lib64/stubs -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-06-03-1100/static/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02840/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-03-1100/static/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02840/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-06-02-0000/static/el8_amd64_gcc12 -lHeterogeneousCoreSonicCore -lFWCoreFramework -lFWCoreCommon -lFWCoreServiceRegistry -lDataFormatsCommon -lFWCoreParameterSet -lHeterogeneousCoreCUDAUtilities -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCorePluginManager -lFWCoreReflection -lFWCoreConcurrency -lFWCoreUtilities -lFWCoreVersion -lTree -lNet -lThread -lMathCore -lRIO -lgrpcclient -ltritoncommonmodelconfig -lboost_program_options -lgrpc -lgrpc++ -lgrpc++_reflection -lCore -lboost_thread -lboost_date_time -lpcre -lbz2 -lcudart -lcudadevrt -lnvToolsExt -lnvidia-ml -luuid -lprotobuf -ltbb -llzma -lz -labsl_bad_any_cast_impl -labsl_bad_optional_access -labsl_bad_variant_access -labsl_base -labsl_city -labsl_civil_time -labsl_cord -labsl_debugging_internal -labsl_demangle_internal -labsl_examine_stack -labsl_exponential_biased -labsl_failure_signal_handler -labsl_flags_commandlineflag_internal -labsl_flags_commandlineflag -labsl_flags_config -labsl_flags_internal -labsl_flags_marshalling -labsl_flags_parse -labsl_flags_private_handle_accessor -labsl_flags_program_name -labsl_flags_reflection -labsl_flags -labsl_flags_usage_internal -labsl_flags_usage -labsl_graphcycles_internal -labsl_hash -labsl_hashtablez_sampler -labsl_int128 -labsl_leak_check -labsl_log_severity -labsl_malloc_internal -labsl_periodic_sampler -labsl_random_distributions -labsl_random_internal_distribution_test_util -labsl_random_internal_platform -labsl_random_internal_pool_urbg -labsl_random_internal_randen_hwaes_impl -labsl_random_internal_randen_hwaes -labsl_random_internal_randen_slow -labsl_random_internal_randen -labsl_random_internal_seed_material -labsl_random_seed_gen_exception -labsl_random_seed_sequences -labsl_raw_hash_set -labsl_raw_logging_internal -labsl_scoped_set_env -labsl_spinlock_wait -labsl_stacktrace -labsl_statusor -labsl_status -labsl_strerror -labsl_str_format_internal -labsl_strings_internal -labsl_strings -labsl_symbolize -labsl_synchronization -labsl_throw_delegate -labsl_time -labsl_time_zone -lcares -lcuda -lfmt -lcms-md5 -lssl -lcrypto -lre2 -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2 /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: tmp/el8_amd64_gcc12/src/HeterogeneousCore/SonicTriton/src/HeterogeneousCoreSonicTriton/ccOWVrh0.ltrans2.ltrans.o: in function `TritonGpuShmResource::TritonGpuShmResource(TritonData*, std::__cxx11::basic_string, std::allocator > const&, unsigned long)': :(.text+0x6480): undefined reference to `triton::client::InferenceServerGrpcClient::RegisterCudaSharedMemory(std::__cxx11::basic_string, std::allocator > const&, cudaIpcMemHandle_st const&, unsigned long, unsigned long, std::map, std::allocator >, std::__cxx11::basic_string, std::allocator >, std::less, std::allocator > >, std::allocator, std::allocator > const, std::__cxx11::basic_string, std::allocator > > > > const&)' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: tmp/el8_amd64_gcc12/src/HeterogeneousCore/SonicTriton/src/HeterogeneousCoreSonicTriton/ccOWVrh0.ltrans2.ltrans.o: in function `TritonGpuShmResource::TritonGpuShmResource(TritonData*, std::__cxx11::basic_string, std::allocator > const&, unsigned long)': :(.text+0x6d40): undefined reference to `triton::client::InferenceServerGrpcClient::RegisterCudaSharedMemory(std::__cxx11::basic_string, std::allocator > const&, cudaIpcMemHandle_st const&, unsigned long, unsigned long, std::map, std::allocator >, std::__cxx11::basic_string, std::allocator >, std::less, std::allocator > >, std::allocator, std::allocator > const, std::__cxx11::basic_string, std::allocator > > > > const&)' collect2: error: ld returned 1 exit status gmake: *** [tmp/el8_amd64_gcc12/src/HeterogeneousCore/SonicTriton/src/HeterogeneousCoreSonicTriton/libHeterogeneousCoreSonicTriton.so] Error 1 Leaving library rule at HeterogeneousCore/SonicTriton Entering library rule at src/HeterogeneousCore/SonicTriton/plugins >> Compiling edm plugin src/HeterogeneousCore/SonicTriton/plugins/TritonService.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_1_X_2024-06-03-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_1_X_2024-06-03-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02840/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-03-1100/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/triton-inference-client/2.25.0-54d5d07371e127286e895420082bfd66/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/grpc/1.35.0-09ace01091c009f51007abf7a6565f16/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-a1544032d9d65904ac2112b6d35bba55/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/cuda/12.4.1-fc5cb0e72dba64b6abbf00089f3a044c/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/protobuf/3.21.9-437f2f0c4a1cda63055784b1b4a72f71/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.30.07-452c1c2d5c71d378bff01d824ff1f3c4/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-1dc6d66b4b014f4ae4733b04914ce7d4/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/abseil-cpp/20220623.1-237da70ecfddbd80ec9c94531c1cbba7/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/c-ares/1.15.0-bf0e2c49330266ca228085a1f6d7a564/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-3ca740c03e68b1a067f3ed0679234a78/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/8.0.1-258b4791803c34b7e98cf43693e54d87/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/re2/2021-06-01-52c3298079c0345449c4fba721c307db/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-88fe0ec301baf763fa3c485e5b67ed91/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++17 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/HeterogeneousCore/SonicTriton/plugins/HeterogenousCoreSonicTriton_plugins/TritonService.cc.d src/HeterogeneousCore/SonicTriton/plugins/TritonService.cc -o tmp/el8_amd64_gcc12/src/HeterogeneousCore/SonicTriton/plugins/HeterogenousCoreSonicTriton_plugins/TritonService.cc.o |
please test |
please test |
Pull request #9218 was updated. |
Pull request #9218 was updated. |
please test |
Pull request #9218 was updated. |
-1 Failed Tests: UnitTests RelVals RelVals-GPU AddOn GpuUnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 2 errors in the following unit tests: ---> test TestDQMOnlineClient-visualization_secondInstance had ERRORS ---> test RecoPPSLocalNewT2 had ERRORS RelValsRelVals-GPUAddOn Tests
Expand to see more addon errors ...
GPU Unit TestsI found 5 errors in the following unit tests: ---> test testAlpakaBackendFilterCudaAsync had ERRORS ---> test testHeterogeneousCoreAlpakaTestModulesCUDA had ERRORS ---> test testHeterogeneousCoreAlpakaTestWriteReadCudaAsync had ERRORS and more ... |
please test |
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test RecoPPSLocalNewT2 had ERRORS Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
The PR proposes following two updates
Allow to have rpm macros in scram toolfiles. This allows to properly generate the toolfiles using the package informaton atbuild time instead of setting env or doing sed/grep in
%post
section. This is done by adding all tools in a single file and then expanding that file with in the actual toolfile or tool-confSupport added to build the stack without optional tools e.g. on Risc-V we do not have rocm/cuda. So using new feature of pkgtools , now we should be able to build the external software tool stack for Risc-V.
cpu_features update to version 0.9.0 which has risc-v support/fixes