Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean offline DQM of Photon "smin" triggers and adding CSCCluster50_Photon20Unseeded #45012

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Clean offline DQM of Photon "smin" triggers and adding CSCCluster50_Photon20Unseeded #45012

merged 2 commits into from
Jun 5, 2024

Conversation

smdogra
Copy link
Contributor

@smdogra smdogra commented May 22, 2024

Hi,

PR description:

As per the JIRA,
https://its.cern.ch/jira/browse/CMSHLT-3081
Clean offline DQM of Photon "smin" triggers and adding the DQM for HLT_CSCcluster50_Photon20Unseeded

The following two files were changed to implement the proposed changes
https://github.com/cms-sw/cmssw/blob/1e2c4980d73549aad8a2c4db1034bd15d2468e0b/DQMOffline/Trigger/python/PhotonMonitor_cff.py
https://github.com/cms-sw/cmssw/blob/1e2c4980d73549aad8a2c4db1034bd15d2468e0b/HLTriggerOffline/Exotica/python/analyses/hltExoticaDisplacedDiPhoton_cff.py

PR validation:

The PR is validated with runTheMatrix.py -l 12834.0 with no error. Th

If this PR is a backport

Not intended

Thank you

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45012/40295

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smdogra for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)
  • HLTriggerOffline/Exotica (dqm)

@tjavaid, @syuvivida, @rvenditti, @cmsbuild, @nothingface0, @antoniovagnerini can you please review it and eventually sign? Thanks.
@rociovilar, @mtosi, @jhgoh, @Fedespring, @trocino, @HuguesBrun, @cericeci, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented May 22, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-babae0/39459/summary.html
COMMIT: a1c0bf2
CMSSW: CMSSW_14_1_X_2024-05-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45012/39459/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 185 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338836
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 206.02399999999997 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 29.432 KiB HLT/EXO
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jun 5, 2024

please test

  • re-triggrering for fresh results

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-babae0/39708/summary.html
COMMIT: a1c0bf2
CMSSW: CMSSW_14_1_X_2024-06-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45012/39708/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338839
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 206.02399999999997 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 29.432 KiB HLT/EXO
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jun 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@mmusich
Copy link
Contributor

mmusich commented Aug 30, 2024

@smdogra should this PR be backported to CMSSW_14_0_X ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants