Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SoA range checking by default #44988

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 16, 2024

PR description:

Enable SoA range checking by default.

PR validation:

None.

Backport status:

To be backported to 14.0.x for data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented May 16, 2024

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44988/40266

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • DataFormats/SoATemplate (heterogeneous)

@makortel, @fwyzard can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a4c79/39412/summary.html
COMMIT: d6d45f7
CMSSW: CMSSW_14_1_X_2024-05-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44988/39412/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338976
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338947
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44988/40284

@cmsbuild
Copy link
Contributor

Pull request #44988 was updated. @cmsbuild, @fwyzard, @makortel can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 20, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a4c79/39431/summary.html
COMMIT: e8ae2ea
CMSSW: CMSSW_14_1_X_2024-05-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44988/39431/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338976
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338950
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor

@fwyzard
What is the status of this and its backport to 14_0?

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 4, 2024

I'm testing what is the impact, both in terms of catching errors, and on the HLT performance.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 4, 2024

The impact on the HLT is less than 1%, from

Running 4 times over 10300 events with 8 jobs, each with 32 threads, 24 streams and 1 GPUs
   694.4 ±   0.2 ev/s (10000 events, 98.0% overlap)
   692.5 ±   0.3 ev/s (10000 events, 97.9% overlap)
   695.4 ±   0.2 ev/s (10000 events, 98.7% overlap)
   692.8 ±   0.2 ev/s (10000 events, 98.4% overlap)
 --------------------
   693.8 ±   1.4 ev/s

to

Running 4 times over 10300 events with 8 jobs, each with 32 threads, 24 streams and 1 GPUs
   688.7 ±   0.2 ev/s (10000 events, 99.5% overlap)
   690.7 ±   0.2 ev/s (10000 events, 98.2% overlap)
   690.7 ±   0.2 ev/s (10000 events, 98.8% overlap)
   691.1 ±   0.2 ev/s (10000 events, 98.7% overlap)
 --------------------
   690.3 ±   1.0 ev/s

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 5, 2024

+heterogeneous

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 5, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 5, 2024

please test

(to refresh the test results)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a4c79/39715/summary.html
COMMIT: e8ae2ea
CMSSW: CMSSW_14_1_X_2024-06-05-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44988/39715/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338836
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 22
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39718
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit aaa1cea into cms-sw:master Jun 5, 2024
14 checks passed
@fwyzard fwyzard deleted the enable_SoA_range_checking_141x branch June 13, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants