[L1T Phase-2] Correlator Layer 1 pattern file producer updates for multi-board tests

[gpetruc]

PR description:

This PR changes the pattern file produces used to prepare inputs for single and multiboard tests for the correlator layer 1, updating the cabling map to what is used at B904 and supporting production of TM18 pattern files also in the barrel.

It doesn't change anything in the physics performance, but it's useful to have it integrated so that other subsystems can have the latest configuration when synchronizing pattern files for multi-board tests.

The corresponding PR to cms-l1t-offline is cms-l1t-offline#1256

PR validation:

Usual stuff:

• code-checks, code-format, ...
• runTheMatrix.py -l 24834.0 (TTbar_14TeV+2026D98)
• L1Trigger/Phase2L1ParticleFlow/test/make_l1ct_binaryFiles_cfg.py with options --tm18 --split18 --serenity to run all the updated pattern file producers

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44963/40236

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @gpetruc for master.

It involves the following packages:

• L1Trigger/Phase2L1ParticleFlow (upgrade, l1)

@epalencia, @subirsarkar, @srimanob, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e69d0/39360/summary.html
COMMIT: 28b0041
CMSSW: CMSSW_14_1_X_2024-05-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44963/39360/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3335848
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3335825
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[gpetruc]

Hello,
Could anyone have a look and comment or sign?
it doesn't change anything that affects production

[aloeliger]

+l1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1