-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bin L1 track quality MVA variable #45011
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45011/40294
|
A new Pull Request was created by @cgsavard for master. It involves the following packages:
@srimanob, @epalencia, @subirsarkar, @aloeliger, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-578667/39463/summary.html Comparison SummarySummary:
|
+l1 |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is the same PR that has been accepted in the L1TK repository here with squashed commits. This bins the track quality variable between a 0-1 range where the binning is set in the TTTrack_Word class in DataFormats. These changes do not affect anything in the current code and is just structural.
PR validation:
Checks have been done to ensure the code is working as expected and that the new structure is not affecting anything. The typical code checks and formatting has also been done.