Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bin L1 track quality MVA variable #45011

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

cgsavard
Copy link
Contributor

PR description:

This is the same PR that has been accepted in the L1TK repository here with squashed commits. This bins the track quality variable between a 0-1 range where the binning is set in the TTTrack_Word class in DataFormats. These changes do not affect anything in the current code and is just structural.

PR validation:

Checks have been done to ensure the code is working as expected and that the new structure is not affecting anything. The typical code checks and formatting has also been done.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45011/40294

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cgsavard for master.

It involves the following packages:

  • DataFormats/L1TrackTrigger (upgrade, l1)
  • L1Trigger/TrackFindingTracklet (l1)
  • L1Trigger/TrackTrigger (upgrade, l1)

@srimanob, @epalencia, @subirsarkar, @aloeliger, @cmsbuild can you please review it and eventually sign? Thanks.
@rovere, @sviret, @missirol, @skinnari, @Martin-Grunewald, @erikbutz this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-578667/39463/summary.html
COMMIT: 41ec1c4
CMSSW: CMSSW_14_1_X_2024-05-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45011/39463/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

+l1

@srimanob
Copy link
Contributor

srimanob commented Jun 3, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants