Correction to cell shapes for partial wafers in v18 version of HGCal

[Pruthvi-ch]

PR description:

Corrections to cell shapes in partial wafers for all orientations or placement index of v18 version of HGCal Geometry

PR validation:

Tested with the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45066/40379

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @Pruthvi-ch for master.

It involves the following packages:

• Geometry/HGCalCommonData (upgrade, geometry)
• SimG4CMS/Calo (simulation)

@bsunanda, @Dr15Jones, @mdhildreth, @civanch, @subirsarkar, @srimanob, @makortel, @cmsbuild can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @ReyerBand, @felicepantaleo, @slomeo, @thomreis, @wang0jin, @rovere this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d6760/39562/summary.html
COMMIT: 65e8ce5
CMSSW: CMSSW_14_1_X_2024-05-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45066/39562/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338833
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[bsunanda]

+geometry

[civanch]

+1

[bsunanda]

@srimanob Please approve this

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1