Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loose bits to uGMT muon shower DQM plots #41182

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Mar 24, 2023

PR description:

This PR adds the (one|two) loose shower bit to the uGMT DQM. Once it's accepted I will create a backport for 13_0_X.

attn: @vukasinmilosevic, @eyigitba, @elfontan

PR validation:

No validation beyond the standard tests possible in the absence of the upstream product.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41182/34866

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

type l1t

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c06c6/31606/summary.html
COMMIT: f096b46
CMSSW: CMSSW_13_1_X_2023-03-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41182/31606/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 29 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554286
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 140
  • DQMHistoTests: Total successes: 3554115
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8.09 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.691 KiB L1T/L1TStage2uGMT
  • DQMHistoSizes: changed ( 11634.0,... ): 0.117 KiB L1TEMU/L1TdeStage2uGMT
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@dinyar
Copy link
Contributor Author

dinyar commented Mar 27, 2023

Checked the changed DQM and they are in line with expectations. Also as expected we don't see any counts for the newly added loose showers yet.

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c3866b2 into cms-sw:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants