Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update G4 11.1.1, vecgeom 1.2.1, clhep 2.4.6 and G4-data #8415

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

smuzaffar
Copy link
Contributor

These are the changes needed to update Geant 4 to version 11.1.1

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8415 was updated.

@smuzaffar
Copy link
Contributor Author

hold

we need to wait for the validation results of Geant4/Geant4LTO builds

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Mar 29, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebf4cd/31677/summary.html
COMMIT: 6a6640b
CMSSW: CMSSW_13_1_X_2023-03-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8415/31677/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebf4cd/31677/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebf4cd/31677/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 221 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 66095 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554236
  • DQMHistoTests: Total failures: 155801
  • DQMHistoTests: Total nulls: 397
  • DQMHistoTests: Total successes: 3398016
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.8409999999999966 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.129 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): 0.691 KiB L1T/L1TStage2uGMT
  • DQMHistoSizes: changed ( 11634.0,... ): 0.117 KiB L1TEMU/L1TdeStage2uGMT
  • DQMHistoSizes: changed ( 11834.0 ): 2.548 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.645 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.361 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -7.198 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): 1.537 KiB SiStrip/MechanicalView
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 17 / 47 workflows

@civanch
Copy link
Contributor

civanch commented Apr 7, 2023

@smuzaffar , at the last PPD meeting April, 6, PdmV team confirmed that they approve validation campaign for 13_0_0_pre3_LTOVECGEOM, so this PR may be unhold.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2023

Pull request #8415 was updated.

@smuzaffar
Copy link
Contributor Author

unhold

@cmsbuild cmsbuild removed the hold label Apr 8, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebf4cd/31893/summary.html
COMMIT: b5a9706
CMSSW: CMSSW_13_1_X_2023-04-07-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8415/31893/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 158 lines from the logs
  • Reco comparison results: 62426 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3459609
  • DQMHistoTests: Total failures: 152514
  • DQMHistoTests: Total nulls: 259
  • DQMHistoTests: Total successes: 3306814
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2.5490000000000004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.129 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 4.247 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.645 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.361 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -7.198 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): 1.537 KiB SiStrip/MechanicalView
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 16 / 46 workflows

@civanch
Copy link
Contributor

civanch commented Apr 10, 2023

@smuzaffar , may be good time to merge it now? Next days we can react if a new problem appears.

@smuzaffar
Copy link
Contributor Author

+externals

lets get this in then

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the g4-11.1.1 branch April 27, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants