Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PGO support #193

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Added PGO support #193

merged 1 commit into from
Apr 3, 2023

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch V00-34-XX.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#8415

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = FWCore,DataFormats

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#8415

@smuzaffar
Copy link
Contributor Author

+externals

external build process worked fine as expected. This change is backward compatible so safe to include

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2023

This pull request is fully signed and it will be integrated in one of the next V00-34-XX IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24dbfa/31751/summary.html
COMMIT: a23f1f8
CMSSW: CMSSW_13_1_X_2023-04-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/pkgtools/193/31751/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24dbfa/31751/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24dbfa/31751/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test HcalPFCuts_unittest had ERRORS

Comparison Summary

Summary:

  • You potentially removed 23 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 58715 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3364817
  • DQMHistoTests: Total failures: 147886
  • DQMHistoTests: Total nulls: 185
  • DQMHistoTests: Total successes: 3216724
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -4.248 KiB( 46 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.129 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 2.548 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.645 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.361 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -7.198 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): 1.537 KiB SiStrip/MechanicalView
  • Checked 202 log files, 155 edm output root files, 47 DQM output files
  • TriggerResults: found differences in 15 / 45 workflows

@smuzaffar smuzaffar deleted the pgo-support branch April 20, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants