Remove unneeded header includes from DQM/CTPPS plugins

[perrotta]

PR description:

As a follow up of #40895, a few unnecessary header includes are removed from the newly added plugins, in order to reduce unnecessary dependencies

Added also the removal of explicit ctppsRandomDQMSource_cfi.py, as suggested by @AndreaBellora , because it is already created automatically by the fillDescriptions method of the plugin

@AndreaBellora FYI

PR validation:

It builds

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41204/34901

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• DQM/CTPPS (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@fabferro, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[AndreaBellora]

Thanks @perrotta! To be fair there is still a useless duplication that I noticed:
DQM/CTPPS/python/ctppsRandomDQMSource_cfi.py is not really needed since DQM/CTPPS/plugins/CTPPSRandomDQMSource.cc contains a fillDescriptions method with the same parameters. I don't want to create delays though, do you think we should fix that too?

[perrotta]

Thanks @perrotta! To be fair there is still a useless duplication that I noticed: DQM/CTPPS/python/ctppsRandomDQMSource_cfi.py is not really needed since DQM/CTPPS/plugins/CTPPSRandomDQMSource.cc contains a fillDescriptions method with the same parameters. I don't want to create delays though, do you think we should fix that too?

Good point!
Yes, let avoid duplicates. If you need to specialize some Offline source later on, you can always add a cff with it.
I'm going to add it to this commit, since I am on it.

[perrotta]

please abort

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41204/34902

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #41204 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41204/34903

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #41204 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again.

[perrotta]

please test

[AndreaBellora]

Thanks @perrotta! To be fair there is still a useless duplication that I noticed: DQM/CTPPS/python/ctppsRandomDQMSource_cfi.py is not really needed since DQM/CTPPS/plugins/CTPPSRandomDQMSource.cc contains a fillDescriptions method with the same parameters. I don't want to create delays though, do you think we should fix that too?

Good point! Yes, let avoid duplicates. If you need to specialize some Offline source later on, you can always add a cff with it. I'm going to add it to this commit, since I am on it.

Thank you!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29e691/31633/summary.html
COMMIT: f23238c
CMSSW: CMSSW_13_1_X_2023-03-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41204/31633/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 26 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3554236
• DQMHistoTests: Total failures: 899
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3553315
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[perrotta]

Reco tracking changes in the mkfit workflow are obviously unrelated

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1