-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQM module for PPS random stream - backport #41049
DQM module for PPS random stream - backport #41049
Conversation
Added new DQM client for the PPSRandom stream
A new Pull Request was created by @AndreaBellora for CMSSW_13_0_X. It involves the following packages:
@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
Hi, after building 13_0_0 with this PR at our playback, I was trying to test this client with the streamer provided by AlcaDB, but then found all the streamers at /eos/cms/store/t0streamer/Data/ALCAPPSExpress/000/ are from 2022 runs (created with 12_4_X or even older versions). In this case, we will not be able to read these streamers due to a mismatch of streamer format. @francescobrivio do we have this type of AlcaPPS streamers that are built with 13_0_X? Also to double check @AndreaBellora did you test your module and client in 13_0_X using these streamers at eos? Eiko |
Hi @syuvivida, I tested the code as mentioned above, but I couldn't really run the client (I need some guidance to do it). |
@syuvivida : i made the request in https://its.cern.ch/jira/browse/CMSHLT-2650 but for the time being no feedback. |
@syuvivida |
@vavati When we switched from 12_4_X to 12_6_X for MWGR, at that time, HLT had to re-run 12_6_X at Hilton on an old 12_4_X collision streamer to make it work. On the other hand, there seems to be no streamer mismatch for 12_6_X vs 13_0_X; so far we are able to run 13_0_0 on the 12_6_3 MWGR cosmic run streamers. |
@syuvivida the files you are trying to read were produced during 2022 data taking
So probably with 12_4. I dont understand why you mention 12_6
…On March 15, 2023 8:18:02 PM GMT+01:00, syuvivida ***@***.***> wrote:
@vavati When we switched from 12_4_X to 12_6_X for MWGR, at that time, HLT had to re-run 12_6_X at Hilton on an old 12_4_X collision streamer to make it work. On the other hand, there seems to be no streamer mismatch for 12_6_X vs 13_0_X; so far we are able to run 13_0_0 on the 12_6_3 MWGR cosmic run streamers.
--
Reply to this email directly or view it on GitHub:
#41049 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
@vavati I meant to say there is a mismatch between 12_4_X streamers and newer release(either 12_6_X or 13_0_X), but not 12_6_X with 13_0_X. |
@syuvivida I don't think it is up to us to provide a conversion of data streamer. The issue is not created by out PR but somewhere else. If data 2022 cannot be used to test then we wait for the new data. |
@vavati this really depends on how urgently you want this implemented. If this can wait until we get new 13_0 streamers then that's the easiest solution. |
hold
|
Pull request has been put on hold by @emanueleusai |
please test |
type ctpps |
Pull request #41049 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again. |
Concerning this, I checked the output and everything looks right in the file |
@syuvivida Please it is up to DQM to organize the test. Today HLT said that the key can prepared to make the live test |
@AndreaBellora DQM has made a production release. If HLT is ready to join, we could switch the production and include pps temporarily, |
…into CMSSW_13_0_0_pre4_RandomDQM
Pull request #41049 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-279dea/31573/summary.html Comparison SummarySummary:
|
@AndreaBellora were you able to test the commit (adding colz, etc) you made yesterday using the streamers we copied to /eos/cms/store/group/comm_dqm/pps_input/? Eiko |
@syuvivida yes, and things turned out as expected. On our side, no further change is needed, besides @francescobrivio suggestions, which will come in a separate PR |
Very well then. I will complete the review soon so we can merge this. |
+1 |
unhold |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
This PR is a backport of #40895