Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataFormats/Scouting tests on PowerPC #41219

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

iarspider
Copy link
Contributor

Redo of #41189

@iarspider
Copy link
Contributor Author

please test for el8_ppc64le_gcc11

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41219/34936

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • DataFormats/Scouting (core)

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test for el8_ppc64le_gcc11

@VinInn
Copy link
Contributor

VinInn commented Mar 29, 2023

adding to the compiler options -mfloat128 It shall compile.
adding -mcpu=power9 (if our target is power9) will even emit the hardware instructions.
see
https://godbolt.org/z/Mqfh33xs7

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdac5d/31675/summary.html
COMMIT: 576cda3
CMSSW: CMSSW_13_1_X_2023-03-28-2300/el8_ppc64le_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41219/31675/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdac5d/31675/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdac5d/31675/git-merge-result

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdac5d/31674/summary.html
COMMIT: 576cda3
CMSSW: CMSSW_13_1_X_2023-03-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41219/31674/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdac5d/31674/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdac5d/31674/git-merge-result

Comparison Summary

Summary:

  • You potentially added 31 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554236
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 140
  • DQMHistoTests: Total successes: 3554067
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8.09 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.691 KiB L1T/L1TStage2uGMT
  • DQMHistoSizes: changed ( 11634.0,... ): 0.117 KiB L1TEMU/L1TdeStage2uGMT
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

adding to the compiler options -mfloat128 It shall compile.

@VinInn , this is coming from rootcling . Issue is in root build of llvm see https://sft.its.cern.ch/jira/browse/ROOT-10879 and #31156 .

@smuzaffar
Copy link
Contributor

+core

technical change which fixes unit tests for ppc64le

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants