Skip to content

Commit

Permalink
Add loose bits to uGMT muon shower DQM plots
Browse files Browse the repository at this point in the history
  • Loading branch information
@dinyar
dinyar committed Mar 24, 2023
1 parent 7530dfd commit f096b46
Show file tree
Hide file tree
Showing 6 changed files with 127 additions and 40 deletions.
21 changes: 16 additions & 5 deletions DQM/L1TMonitor/interface/L1TStage2MuonShowerComp.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,21 @@ class L1TStage2MuonShowerComp : public DQMEDAnalyzer {
void analyze(const edm::Event&, const edm::EventSetup&) override;

private:
enum variables { BXRANGEGOOD = 1, BXRANGEBAD, NSHOWERGOOD, NSHOWERBAD, SHOWERALL, SHOWERGOOD, NOMINALBAD, TIGHTBAD };
enum ratioVariables { RBXRANGE = 1, RNSHOWER, RSHOWER, RNOMINAL, RTIGHT };
int numSummaryBins_{TIGHTBAD};
int numErrBins_{RTIGHT};
bool incBin_[RTIGHT + 1];
enum variables {
BXRANGEGOOD = 1,
BXRANGEBAD,
NSHOWERGOOD,
NSHOWERBAD,
SHOWERALL,
SHOWERGOOD,
NOMINALBAD,
TIGHTBAD,
LOOSEBAD
};
enum ratioVariables { RBXRANGE = 1, RNSHOWER, RSHOWER, RNOMINAL, RTIGHT, RLOOSE };
int numSummaryBins_{LOOSEBAD};
int numErrBins_{RLOOSE};
bool incBin_[RLOOSE + 1];

edm::EDGetTokenT<l1t::MuonShowerBxCollection> showerToken1_;
edm::EDGetTokenT<l1t::MuonShowerBxCollection> showerToken2_;
Expand All @@ -50,6 +60,7 @@ class L1TStage2MuonShowerComp : public DQMEDAnalyzer {
MonitorElement* showerColl2nShowers_;
MonitorElement* showerColl2ShowerTypeVsBX_;

static constexpr unsigned IDX_LOOSE_SHOWER{3};
static constexpr unsigned IDX_TIGHT_SHOWER{2};
static constexpr unsigned IDX_NOMINAL_SHOWER{1};
};
Expand Down
21 changes: 16 additions & 5 deletions DQM/L1TMonitor/interface/L1TStage2RegionalMuonShowerComp.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,22 @@ class L1TStage2RegionalMuonShowerComp : public DQMEDAnalyzer {
void analyze(const edm::Event&, const edm::EventSetup&) override;

private:
enum variables { BXRANGEGOOD = 1, BXRANGEBAD, NSHOWERGOOD, NSHOWERBAD, SHOWERALL, SHOWERGOOD, NOMINALBAD, TIGHTBAD };
enum ratioVariables { RBXRANGE = 1, RNSHOWER, RSHOWER, RNOMINAL, RTIGHT };
enum variables {
BXRANGEGOOD = 1,
BXRANGEBAD,
NSHOWERGOOD,
NSHOWERBAD,
SHOWERALL,
SHOWERGOOD,
NOMINALBAD,
TIGHTBAD,
LOOSEBAD
};
enum ratioVariables { RBXRANGE = 1, RNSHOWER, RSHOWER, RNOMINAL, RTIGHT, RLOOSE };
enum tfs { EMTFNEGBIN = 1, EMTFPOSBIN };
int numSummaryBins_{TIGHTBAD};
int numErrBins_{RTIGHT};
bool incBin_[RTIGHT + 1];
int numSummaryBins_{LOOSEBAD};
int numErrBins_{RLOOSE};
bool incBin_[RLOOSE + 1];

edm::EDGetTokenT<l1t::RegionalMuonShowerBxCollection> showerToken1_;
edm::EDGetTokenT<l1t::RegionalMuonShowerBxCollection> showerToken2_;
Expand All @@ -55,6 +65,7 @@ class L1TStage2RegionalMuonShowerComp : public DQMEDAnalyzer {
MonitorElement* showerColl2ShowerTypeVsBX_;
MonitorElement* showerColl2ProcessorVsBX_;

static constexpr unsigned IDX_LOOSE_SHOWER{3};
static constexpr unsigned IDX_TIGHT_SHOWER{2};
static constexpr unsigned IDX_NOMINAL_SHOWER{1};
};
Expand Down
1 change: 1 addition & 0 deletions DQM/L1TMonitor/interface/L1TStage2uGMT.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ class L1TStage2uGMT : public DQMEDAnalyzer {
MonitorElement* ugmtMuMuDPhiEneg;
MonitorElement* ugmtMuMuDREneg;

static constexpr unsigned IDX_LOOSE_SHOWER{3};
static constexpr unsigned IDX_TIGHT_SHOWER{2};
static constexpr unsigned IDX_NOMINAL_SHOWER{1};
};
Expand Down
32 changes: 24 additions & 8 deletions DQM/L1TMonitor/src/L1TStage2MuonShowerComp.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ void L1TStage2MuonShowerComp::bookHistograms(DQMStore::IBooker& ibooker, const e
summary_->setBinLabel(SHOWERGOOD, "# matching showers", 1);
summary_->setBinLabel(NOMINALBAD, "nominal shower mismatch", 1);
summary_->setBinLabel(TIGHTBAD, "tight shower mismatch", 1);
summary_->setBinLabel(LOOSEBAD, "loose shower mismatch", 1);

errorSummaryNum_ = ibooker.book1D("errorSummaryNum",
summaryTitle_.c_str(),
Expand All @@ -67,6 +68,7 @@ void L1TStage2MuonShowerComp::bookHistograms(DQMStore::IBooker& ibooker, const e
errorSummaryNum_->setBinLabel(RSHOWER, "mismatching showers", 1);
errorSummaryNum_->setBinLabel(RNOMINAL, "nominal shower mismatch", 1);
errorSummaryNum_->setBinLabel(RTIGHT, "tight shower mismatch", 1);
errorSummaryNum_->setBinLabel(RLOOSE, "loose shower mismatch", 1);

// Change the label for those bins that will be ignored
for (int i = 1; i <= errorSummaryNum_->getNbinsX(); i++) {
Expand Down Expand Up @@ -100,13 +102,14 @@ void L1TStage2MuonShowerComp::bookHistograms(DQMStore::IBooker& ibooker, const e
7,
-3.5,
3.5,
2,
3,
1,
3);
4);
showerColl1ShowerTypeVsBX_->setAxisTitle("BX", 1);
showerColl1ShowerTypeVsBX_->setAxisTitle("Shower type", 2);
showerColl1ShowerTypeVsBX_->setBinLabel(IDX_TIGHT_SHOWER, "Tight", 2);
showerColl1ShowerTypeVsBX_->setBinLabel(IDX_NOMINAL_SHOWER, "Nominal", 2);
showerColl1ShowerTypeVsBX_->setBinLabel(IDX_LOOSE_SHOWER, "TwoLoose", 2);
showerColl1ShowerTypeVsBX_->setBinLabel(IDX_TIGHT_SHOWER, "OneTight", 2);
showerColl1ShowerTypeVsBX_->setBinLabel(IDX_NOMINAL_SHOWER, "OneNominal", 2);

showerColl2BxRange_ =
ibooker.book1D("showerBxRangeColl2", (showerColl2Title_ + " mismatching BX range").c_str(), 11, -5.5, 5.5);
Expand All @@ -119,13 +122,14 @@ void L1TStage2MuonShowerComp::bookHistograms(DQMStore::IBooker& ibooker, const e
7,
-3.5,
3.5,
2,
3,
1,
3);
4);
showerColl2ShowerTypeVsBX_->setAxisTitle("BX", 1);
showerColl2ShowerTypeVsBX_->setAxisTitle("Shower type", 2);
showerColl2ShowerTypeVsBX_->setBinLabel(IDX_TIGHT_SHOWER, "Tight", 2);
showerColl2ShowerTypeVsBX_->setBinLabel(IDX_NOMINAL_SHOWER, "Nominal", 2);
showerColl2ShowerTypeVsBX_->setBinLabel(IDX_LOOSE_SHOWER, "TwoLoose", 2);
showerColl2ShowerTypeVsBX_->setBinLabel(IDX_TIGHT_SHOWER, "OneTight", 2);
showerColl2ShowerTypeVsBX_->setBinLabel(IDX_NOMINAL_SHOWER, "OneNominal", 2);
}

void L1TStage2MuonShowerComp::analyze(const edm::Event& e, const edm::EventSetup& c) {
Expand Down Expand Up @@ -184,6 +188,9 @@ void L1TStage2MuonShowerComp::analyze(const edm::Event& e, const edm::EventSetup
if (showerIt1->isOneTightInTime()) {
showerColl1ShowerTypeVsBX_->Fill(IDX_TIGHT_SHOWER, iBx);
}
if (showerIt1->isTwoLooseDiffSectorsInTime()) {
showerColl1ShowerTypeVsBX_->Fill(IDX_LOOSE_SHOWER, iBx);
}
}
} else {
showerIt2 = showerBxColl2->begin(iBx) + showerBxColl1->size(iBx);
Expand All @@ -194,6 +201,9 @@ void L1TStage2MuonShowerComp::analyze(const edm::Event& e, const edm::EventSetup
if (showerIt2->isOneTightInTime()) {
showerColl2ShowerTypeVsBX_->Fill(IDX_TIGHT_SHOWER, iBx);
}
if (showerIt2->isTwoLooseDiffSectorsInTime()) {
showerColl2ShowerTypeVsBX_->Fill(IDX_LOOSE_SHOWER, iBx);
}
}
}
} else {
Expand Down Expand Up @@ -238,13 +248,19 @@ void L1TStage2MuonShowerComp::analyze(const edm::Event& e, const edm::EventSetup
if (showerIt1->isOneTightInTime()) {
showerColl1ShowerTypeVsBX_->Fill(IDX_TIGHT_SHOWER, iBx);
}
if (showerIt1->isTwoLooseDiffSectorsInTime()) {
showerColl1ShowerTypeVsBX_->Fill(IDX_LOOSE_SHOWER, iBx);
}

if (showerIt2->isOneNominalInTime()) {
showerColl2ShowerTypeVsBX_->Fill(IDX_NOMINAL_SHOWER, iBx);
}
if (showerIt2->isOneTightInTime()) {
showerColl2ShowerTypeVsBX_->Fill(IDX_TIGHT_SHOWER, iBx);
}
if (showerIt2->isTwoLooseDiffSectorsInTime()) {
showerColl2ShowerTypeVsBX_->Fill(IDX_LOOSE_SHOWER, iBx);
}
} else {
summary_->Fill(SHOWERGOOD);
}
Expand Down
70 changes: 54 additions & 16 deletions DQM/L1TMonitor/src/L1TStage2RegionalMuonShowerComp.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ void L1TStage2RegionalMuonShowerComp::bookHistograms(DQMStore::IBooker& ibooker,
summary_->setBinLabel(SHOWERGOOD, "# matching showers", 1);
summary_->setBinLabel(NOMINALBAD, "nominal shower mismatch", 1);
summary_->setBinLabel(TIGHTBAD, "tight shower mismatch", 1);
summary_->setBinLabel(LOOSEBAD, "loose shower mismatch", 1);

errorSummaryNum_ = ibooker.book1D("errorSummaryNum",
summaryTitle_.c_str(),
Expand All @@ -71,6 +72,7 @@ void L1TStage2RegionalMuonShowerComp::bookHistograms(DQMStore::IBooker& ibooker,
errorSummaryNum_->setBinLabel(RSHOWER, "mismatching showers", 1);
errorSummaryNum_->setBinLabel(RNOMINAL, "nominal shower mismatch", 1);
errorSummaryNum_->setBinLabel(RTIGHT, "tight shower mismatch", 1);
errorSummaryNum_->setBinLabel(RLOOSE, "loose shower mismatch", 1);

// Change the label for those bins that will be ignored
for (int i = 1; i <= errorSummaryNum_->getNbinsX(); i++) {
Expand Down Expand Up @@ -105,9 +107,9 @@ void L1TStage2RegionalMuonShowerComp::bookHistograms(DQMStore::IBooker& ibooker,
12,
1,
13,
2,
3,
1,
3);
4);
showerColl1ShowerTypeVsProcessor_->setAxisTitle("Processor", 1);
showerColl1ShowerTypeVsProcessor_->setBinLabel(12, "+6", 1);
showerColl1ShowerTypeVsProcessor_->setBinLabel(11, "+5", 1);
Expand All @@ -122,20 +124,22 @@ void L1TStage2RegionalMuonShowerComp::bookHistograms(DQMStore::IBooker& ibooker,
showerColl1ShowerTypeVsProcessor_->setBinLabel(2, "-2", 1);
showerColl1ShowerTypeVsProcessor_->setBinLabel(1, "-1", 1);
showerColl1ShowerTypeVsProcessor_->setAxisTitle("Shower type", 2);
showerColl1ShowerTypeVsProcessor_->setBinLabel(IDX_TIGHT_SHOWER, "Tight", 2);
showerColl1ShowerTypeVsProcessor_->setBinLabel(IDX_NOMINAL_SHOWER, "Nominal", 2);
showerColl1ShowerTypeVsProcessor_->setBinLabel(IDX_LOOSE_SHOWER, "OneLoose", 2);
showerColl1ShowerTypeVsProcessor_->setBinLabel(IDX_TIGHT_SHOWER, "OneTight", 2);
showerColl1ShowerTypeVsProcessor_->setBinLabel(IDX_NOMINAL_SHOWER, "OneNominal", 2);
showerColl1ShowerTypeVsBX_ = ibooker.book2D("showerColl1ShowerTypeVsBX",
showerColl1Title_ + " mismatching shower type occupancy per BX",
7,
-3.5,
3.5,
2,
3,
1,
3);
4);
showerColl1ShowerTypeVsBX_->setAxisTitle("BX", 1);
showerColl1ShowerTypeVsBX_->setAxisTitle("Shower type", 2);
showerColl1ShowerTypeVsBX_->setBinLabel(IDX_TIGHT_SHOWER, "Tight", 2);
showerColl1ShowerTypeVsBX_->setBinLabel(IDX_NOMINAL_SHOWER, "Nominal", 2);
showerColl1ShowerTypeVsBX_->setBinLabel(IDX_LOOSE_SHOWER, "OneLoose", 2);
showerColl1ShowerTypeVsBX_->setBinLabel(IDX_TIGHT_SHOWER, "OneTight", 2);
showerColl1ShowerTypeVsBX_->setBinLabel(IDX_NOMINAL_SHOWER, "OneNominal", 2);
showerColl1ProcessorVsBX_ = ibooker.book2D("showerColl1ProcessorVsBX",
showerColl1Title_ + " mismatching shower BX occupancy per sector",
7,
Expand Down Expand Up @@ -171,9 +175,9 @@ void L1TStage2RegionalMuonShowerComp::bookHistograms(DQMStore::IBooker& ibooker,
12,
1,
13,
2,
3,
1,
3);
4);
showerColl2ShowerTypeVsProcessor_->setAxisTitle("Processor", 1);
showerColl2ShowerTypeVsProcessor_->setBinLabel(12, "+6", 1);
showerColl2ShowerTypeVsProcessor_->setBinLabel(11, "+5", 1);
Expand All @@ -188,20 +192,22 @@ void L1TStage2RegionalMuonShowerComp::bookHistograms(DQMStore::IBooker& ibooker,
showerColl2ShowerTypeVsProcessor_->setBinLabel(2, "-2", 1);
showerColl2ShowerTypeVsProcessor_->setBinLabel(1, "-1", 1);
showerColl2ShowerTypeVsProcessor_->setAxisTitle("Shower type", 2);
showerColl2ShowerTypeVsProcessor_->setBinLabel(IDX_TIGHT_SHOWER, "Tight", 2);
showerColl2ShowerTypeVsProcessor_->setBinLabel(IDX_NOMINAL_SHOWER, "Nominal", 2);
showerColl2ShowerTypeVsProcessor_->setBinLabel(IDX_LOOSE_SHOWER, "OneLoose", 2);
showerColl2ShowerTypeVsProcessor_->setBinLabel(IDX_TIGHT_SHOWER, "OneTight", 2);
showerColl2ShowerTypeVsProcessor_->setBinLabel(IDX_NOMINAL_SHOWER, "OneNominal", 2);
showerColl2ShowerTypeVsBX_ = ibooker.book2D("showerColl2ShowerTypeVsBX",
showerColl2Title_ + " mismatching shower type occupancy per BX",
7,
-3.5,
3.5,
2,
3,
1,
3);
4);
showerColl2ShowerTypeVsBX_->setAxisTitle("BX", 1);
showerColl2ShowerTypeVsBX_->setAxisTitle("Shower type", 2);
showerColl2ShowerTypeVsBX_->setBinLabel(IDX_TIGHT_SHOWER, "Tight", 2);
showerColl2ShowerTypeVsBX_->setBinLabel(IDX_NOMINAL_SHOWER, "Nominal", 2);
showerColl2ShowerTypeVsBX_->setBinLabel(IDX_TIGHT_SHOWER, "OneLoose", 2);
showerColl2ShowerTypeVsBX_->setBinLabel(IDX_TIGHT_SHOWER, "OneTight", 2);
showerColl2ShowerTypeVsBX_->setBinLabel(IDX_NOMINAL_SHOWER, "OneNominal", 2);
showerColl2ProcessorVsBX_ = ibooker.book2D("showerColl2ProcessorVsBX",
showerColl2Title_ + " mismatching shower BX occupancy per sector",
7,
Expand Down Expand Up @@ -287,6 +293,12 @@ void L1TStage2RegionalMuonShowerComp::analyze(const edm::Event& e, const edm::Ev
showerIt1->processor() + 1 + (showerIt1->trackFinderType() == l1t::tftype::emtf_pos ? 6 : 0));
showerColl1ShowerTypeVsBX_->Fill(IDX_TIGHT_SHOWER, iBx);
}
if (showerIt1->isOneLooseInTime()) {
showerColl1ShowerTypeVsProcessor_->Fill(
IDX_LOOSE_SHOWER,
showerIt1->processor() + 1 + (showerIt1->trackFinderType() == l1t::tftype::emtf_pos ? 6 : 0));
showerColl1ShowerTypeVsBX_->Fill(IDX_LOOSE_SHOWER, iBx);
}
showerColl1ProcessorVsBX_->Fill(
showerIt1->processor() + 1 + (showerIt1->trackFinderType() == l1t::tftype::emtf_pos ? 6 : 0), iBx);
}
Expand All @@ -305,6 +317,12 @@ void L1TStage2RegionalMuonShowerComp::analyze(const edm::Event& e, const edm::Ev
showerIt2->processor() + 1 + (showerIt2->trackFinderType() == l1t::tftype::emtf_pos ? 6 : 0));
showerColl2ShowerTypeVsBX_->Fill(IDX_TIGHT_SHOWER, iBx);
}
if (showerIt2->isOneLooseInTime()) {
showerColl2ShowerTypeVsProcessor_->Fill(
IDX_LOOSE_SHOWER,
showerIt2->processor() + 1 + (showerIt2->trackFinderType() == l1t::tftype::emtf_pos ? 6 : 0));
showerColl2ShowerTypeVsBX_->Fill(IDX_LOOSE_SHOWER, iBx);
}
showerColl2ProcessorVsBX_->Fill(
showerIt2->processor() + 1 + (showerIt2->trackFinderType() == l1t::tftype::emtf_pos ? 6 : 0), iBx);
}
Expand Down Expand Up @@ -339,6 +357,14 @@ void L1TStage2RegionalMuonShowerComp::analyze(const edm::Event& e, const edm::Ev
errorSummaryNum_->Fill(RTIGHT);
}
}
if (showerIt1->isOneLooseInTime() != showerIt2->isOneLooseInTime()) {
showerMismatch = true;
summary_->Fill(LOOSEBAD);
if (incBin_[RLOOSE]) {
showerSelMismatch = true;
errorSummaryNum_->Fill(RLOOSE);
}
}
if (incBin_[RSHOWER] && showerSelMismatch) {
errorSummaryNum_->Fill(RSHOWER);
}
Expand All @@ -356,6 +382,12 @@ void L1TStage2RegionalMuonShowerComp::analyze(const edm::Event& e, const edm::Ev
showerIt1->processor() + 1 + (showerIt1->trackFinderType() == l1t::tftype::emtf_pos ? 6 : 0));
showerColl1ShowerTypeVsBX_->Fill(IDX_TIGHT_SHOWER, iBx);
}
if (showerIt1->isOneLooseInTime()) {
showerColl1ShowerTypeVsProcessor_->Fill(
IDX_LOOSE_SHOWER,
showerIt1->processor() + 1 + (showerIt1->trackFinderType() == l1t::tftype::emtf_pos ? 6 : 0));
showerColl1ShowerTypeVsBX_->Fill(IDX_LOOSE_SHOWER, iBx);
}
showerColl1ProcessorVsBX_->Fill(
showerIt1->processor() + 1 + (showerIt1->trackFinderType() == l1t::tftype::emtf_pos ? 6 : 0), iBx);

Expand All @@ -371,6 +403,12 @@ void L1TStage2RegionalMuonShowerComp::analyze(const edm::Event& e, const edm::Ev
showerIt2->processor() + 1 + (showerIt2->trackFinderType() == l1t::tftype::emtf_pos ? 6 : 0));
showerColl2ShowerTypeVsBX_->Fill(IDX_TIGHT_SHOWER, iBx);
}
if (showerIt2->isOneLooseInTime()) {
showerColl2ShowerTypeVsProcessor_->Fill(
IDX_LOOSE_SHOWER,
showerIt2->processor() + 1 + (showerIt2->trackFinderType() == l1t::tftype::emtf_pos ? 6 : 0));
showerColl2ShowerTypeVsBX_->Fill(IDX_LOOSE_SHOWER, iBx);
}
showerColl2ProcessorVsBX_->Fill(
showerIt2->processor() + 1 + (showerIt2->trackFinderType() == l1t::tftype::emtf_pos ? 6 : 0), iBx);

Expand Down
Loading

0 comments on commit f096b46

Please sign in to comment.