Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Add loose bits to uGMT muon shower DQM plots #41216

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Mar 29, 2023

PR description:

This PR backports the (one|two) loose shower bit to the uGMT DQM for 13_0_X.

attn: @vukasinmilosevic, @eyigitba, @elfontan

PR validation:

No validation (beyond running standard tests) possible as there are no upstream producers for the required data, yet.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #41182

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2023

A new Pull Request was created by @dinyar (Dinyar Rabady) for CMSSW_13_0_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #41182

@perrotta
Copy link
Contributor

please test

@dinyar dinyar changed the title Add loose bits to uGMT muon shower DQM plots [13_0_X] Add loose bits to uGMT muon shower DQM plots Apr 3, 2023
@rappoccio
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2023

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Apr 3, 2023
@perrotta
Copy link
Contributor

perrotta commented Apr 7, 2023

please test
(tests launched in #41216 (comment) do not have started...)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7e833/31881/summary.html
COMMIT: e757d96
CMSSW: CMSSW_13_0_X_2023-04-06-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41216/31881/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3553952
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 140
  • DQMHistoTests: Total successes: 3553784
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8.09 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.691 KiB L1T/L1TStage2uGMT
  • DQMHistoSizes: changed ( 11634.0,... ): 0.117 KiB L1TEMU/L1TdeStage2uGMT
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@perrotta
Copy link
Contributor

unhold
(even if issue #41246 cannot be considered fully resolved yet, it was however verified that the problem is not in these L1T PRs themselves, which can therefore get backported)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants