Revert "[13_0_X] Update muon shower data formats for 2023 running"

[perrotta]

Reverts #41198
Just in case the investigations on issue #41246 suggest to build a new release without this PR.
At the moment this revert PR is only intended to verify that it is still mergeable in 13_0_X, and it can run.

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for CMSSW_13_0_X.

It involves the following packages:

• DataFormats/L1TMuon (l1)
• DataFormats/L1Trigger (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@kreczko, @JanFSchulte, @rovere, @eyigitba, @missirol, @thomreis, @dinyar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[aloeliger]

@perrotta I haven't been following the issue thread after much after it was first closed. Please ping me if this becomes necessary and I'll inform the responsible L1 people.

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b77d15/31757/summary.html
COMMIT: 85ad941
CMSSW: CMSSW_13_0_X_2023-04-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41257/31757/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-04-03-1100/src/L1Trigger/L1TMuon/src/MuonRawDigiTranslator.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-04-03-1100/src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-04-03-1100/src/L1Trigger/L1TMuon/src/SubsystemCollector.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-04-03-1100/src/L1Trigger/L1TMuon/src/SubsystemCollectorFactory.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-04-03-1100/src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc: In static member function 'static bool l1t::RegionalMuonRawDigiTranslator::fillRegionalMuonShower(l1t::RegionalMuonShower&, std::vector, int, l1t::tftype, bool, bool)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-04-03-1100/src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc:135:14: error: 'class l1t::RegionalMuonShower' has no member named 'setOneLooseInTime'; did you mean 'setTwoLooseInTime'?
  135 |     muShower.setOneLooseInTime(((bxPayload[kEmtfShowerExtendedFrame] >> kEmtfShowerOneLooseShift) & 1) == 1);
      |              ^~~~~~~~~~~~~~~~~
      |              setTwoLooseInTime
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-04-03-1100/src/L1Trigger/L1TMuon/src/MuonRawDigiTranslator.cc: In static member function 'static std::array, 2> l1t::MuonRawDigiTranslator::getPackedShowerDataWords(const l1t::MuonShower&, int, int)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-04-03-1100/src/L1Trigger/L1TMuon/src/MuonRawDigiTranslator.cc:284:30: error: 'const class l1t::MuonShower' has no member named 'isTwoLooseDiffSectorsInTime'


[dinyar]

In case this does need to be reverted we'll also need to revert #41207 and #41206. (Also: we might want to hold off on merging #41216 until the issue is understood as it also needs the change to the data formats.)

-d