Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Update muon shower data formats for 2023 running #41198

Merged

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Mar 27, 2023

PR description:

Backport of the update for the muon shower data formats (RegionalMuonShower and MuonShower) containing the changes that I think are needed for 2023 running.

attn @elfontan and @eyigitba

PR validation:

Similar as for the original PR there isn't much validation that can be done yet apart from the standard tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #40890 to CMSSW 13_0_X

Also clean up MuonShower data format a bit.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2023

A new Pull Request was created by @dinyar (Dinyar Rabady) for CMSSW_13_0_X.

It involves the following packages:

  • DataFormats/L1TMuon (l1)
  • DataFormats/L1Trigger (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@kreczko, @JanFSchulte, @rovere, @eyigitba, @missirol, @thomreis this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@dinyar dinyar changed the title Update muon shower data formats for 2023 running [13_0_X] Update muon shower data formats for 2023 running Mar 27, 2023
@aloeliger
Copy link
Contributor

backport of #40890

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa183d/31626/summary.html
COMMIT: fa4424a
CMSSW: CMSSW_13_0_X_2023-03-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41198/31626/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554529
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554497
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants