Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loose showers to uGMT shower bit vs. BX DQM plot #41448

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Apr 27, 2023

PR description:

This PR adds the loose showers from EMTF to the uGMT shower bit vs. BX DQM plot. (This one plot was forgotten in #41182.)

PR validation:

Ran the usual commands to check formatting etc.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41448/35308

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce2476/32227/summary.html
COMMIT: 146f4c6
CMSSW: CMSSW_13_1_X_2023-04-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41448/32227/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460877
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460845
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link
Contributor

@emanueleusai can you sign this one as well? The backport is also needed for the next 13_0_X

@perrotta
Copy link
Contributor

perrotta commented Apr 28, 2023

+1

  • The identical backport PR in 13_0_X was signed by DQM with motivation "Already tested at playback and deployed in production online DQM": I assume the same motivation can also hold here in master.
  • Let merge this in master, so that the backport can also get merged after it, and enter the next release for data taking

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit caeae41 into cms-sw:master Apr 28, 2023
@perrotta
Copy link
Contributor

@emanueleusai can you sign this one as well? The backport is also needed for the next 13_0_X

Sorry Sal, we overlapped: well, dqm does not have to bother with this signature now, and they can deal with the other missing ones

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants