Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stuck-TBM specific workflows #27692

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 5, 2019

PR description:

PR #25524 introduced two specific workflows to be able to test the SiPixel Bad FED Channel simulation (a.k.a. stuck-TBM simulation).
With the activation of the feature by default in PR #26275 and the provision of Ultra-Legacy conditions for the records SiPixelStatusScenarioProbabilityRcd and SiPixelStatusScenariosRcd for the 2017 MC in PR #27342 and for 2018 MC in PR #27683, these workflows are now superfluous and can be removed.

PR validation:

Run the usual limited matrix tests:

$ runTheMatrix.py -l limited -t 4 -j 8 --ibeos

which completed without errors.

if this PR is a backport please specify the original PR:

This PR is not a backport

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27692/11294

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2019

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/PyReleaseValidation
SimTracker/SiPixelDigitizer

@cmsbuild, @prebello, @zhenhu, @civanch, @kpedro88, @pgunnell, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dkotlins, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Aug 5, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1835/console Started: 2019/08/05 17:49

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56ac12/1835/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-56ac12/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 2715989
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2715659
  • DQMHistoTests: Total skipped: 329
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor

civanch commented Aug 5, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Aug 6, 2019

@prebello @zhenhu this move makes sense to me, could you please check and approve it?

@prebello
Copy link
Contributor

prebello commented Aug 6, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Aug 8, 2019

+1

@kpedro88 please have a look at your earliest convenience, I believe it is ok to move forward

@fabiocos
Copy link
Contributor

fabiocos commented Aug 8, 2019

merge

@cmsbuild cmsbuild merged commit aaf13dc into cms-sw:master Aug 8, 2019
@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants