DD4hep: Numeric vector units parsing

[vargasa]

PR description:

Addresses missing parsing of units in DDNamespace::vecDbl

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27725/11347

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @vargasa (Andrés Vargas) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1905/console Started: 2019/08/08 13:42

[cmsbuild]

+1
Tested at: 6fdf8bc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9190f6/1905/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• HGCal - Minimum Cluster size for Pattern Recognition #27666 @felicepantaleo: HGCal - Minimum Cluster size for Pattern Recognition
• Fix pixel fiducial volume selection for cosmics #27690 @jandrea: Fix pixel fiducial volume selection for cosmics
• remove stuck-TBM specific workflows #27692 @mmusich: remove stuck-TBM specific workflows
• shared_ptr has arrived to the standard. NFC #27625 @vgvassilev: shared_ptr has arrived to the standard. NFC

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9190f6/1905/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9190f6/1905/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9190f6/1905/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 2715989
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2715659
• DQMHistoTests: Total skipped: 329
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[ianna]

+1

Thanks, @vargasa ! Good work!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[ianna]

urgent

[fabiocos]

@vargasa @ianna for the use that is done so far of this include this update should be irrelevant, but it brings full consistency with all the rest of the package

[vargasa]

@fabiocos. It is for consistency sake. The function used here cms_units::operators::convertRadToDeg points to angle_units::operators::convertRadToDeg(here) which is the same endpoint used by geant_units (here).

[fabiocos]

+1